fix: ensure all effect cleanup functions are untracked (#11567)

* fix: ensure all effect cleanup functions are untracked

* add test

---------

Co-authored-by: Rich Harris <[email protected]>

Author: trueadm

.changeset/dirty-eyes-itch.md

@@ -0,0 +1,5 @@
+---
+"svelte": patch
+---
+
+fix: ensure all effect cleanup functions are untracked

packages/svelte/src/internal/client/reactivity/effects.js

@@ -3,6 +3,7 @@ import {
 	current_component_context,
 	current_effect,
 	current_reaction,
+	current_untracking,
 	destroy_effect_children,
 	dev_current_component_function,
 	execute_effect,
@@ -14,6 +15,7 @@ import {
 	set_is_destroying_effect,
 	set_is_flushing_effect,
 	set_signal_status,
+	set_untracking,
 	untrack
 } from '../runtime.js';
 import {
@@ -295,11 +297,14 @@ export function execute_effect_teardown(effect) {
 	var teardown = effect.teardown;
 	if (teardown !== null) {
 		const previously_destroying_effect = is_destroying_effect;
+		const previous_untracking = current_untracking;
 		set_is_destroying_effect(true);
+		set_untracking(true);
 		try {
 			teardown.call(null);
 		} finally {
 			set_is_destroying_effect(previously_destroying_effect);
+			set_untracking(previous_untracking);
 		}
 	}
 }

packages/svelte/src/internal/client/runtime.js

@@ -48,6 +48,11 @@ export function set_is_destroying_effect(value) {
 	is_destroying_effect = value;
 }
 
+/** @param {boolean} value */
+export function set_untracking(value) {
+	current_untracking = value;
+}
+
 // Used for $inspect
 export let is_batching_effect = false;
 let is_inspecting_signal = false;

packages/svelte/tests/runtime-runes/samples/effect-untrack-teardown/_config.js

@@ -0,0 +1,4 @@
+import { test } from '../../test';
+
+// nothing to test here — if the teardown function is not untracked, effect will loop
+export default test({});

packages/svelte/tests/runtime-runes/samples/effect-untrack-teardown/main.svelte

@@ -0,0 +1,19 @@
+<script>
+	let prop = $state();
+	let key = $state({});
+
+	function action() {
+		prop = {};
+		$effect.pre(() => {
+			return () => {
+				prop;
+			}
+		});
+	}
+
+	$effect(() => key = {});
+</script>
+
+{#key key}
+	<div use:action>test</div>
+{/key}