Merge remote-tracking branch 'origin/main' into no-navigation-without-base

Author: baseballyama

.changeset/blue-panthers-run.md

@@ -0,0 +1,5 @@
+---
+'eslint-plugin-svelte': patch
+---
+
+fix: support each blocks without an item

.changeset/hungry-grapes-shave.md

@@ -0,0 +1,5 @@
+---
+'eslint-plugin-svelte': patch
+---
+
+chore: update `svelte-eslint-parser` to v1.0.0-next.4

.changeset/pre.json

@@ -8,6 +8,7 @@
   "changesets": [
     "cool-rockets-allow",
     "fast-coins-fly",
+    "hungry-grapes-shave",
     "lazy-eyes-wait",
     "olive-wolves-travel",
     "quiet-toys-burn",

.changeset/sixty-news-look.md

@@ -0,0 +1,5 @@
+---
+'eslint-plugin-svelte': minor
+---
+
+feat: support Svelte5 of `valid-prop-names-in-kit-pages` rule

README.md

@@ -10,8 +10,6 @@ You can check on the [Online DEMO](https://eslint-online-playground.netlify.app/
 > For example, <https://github.com/sveltejs/eslint-plugin-svelte/blob/eslint-plugin-svelte%402.46.0/README.md>
 > and <https://github.com/sveltejs/eslint-plugin-svelte/blob/eslint-plugin-svelte%402.46.0/docs>
 
-**_We are working on experimental support for Svelte v5, but may break with new versions of Svelte v5._**
-
 [![NPM license](https://img.shields.io/npm/l/eslint-plugin-svelte.svg)](https://www.npmjs.com/package/eslint-plugin-svelte)
 [![NPM version](https://img.shields.io/npm/v/eslint-plugin-svelte.svg)](https://www.npmjs.com/package/eslint-plugin-svelte)
 [![NPM downloads](https://img.shields.io/badge/dynamic/json.svg?label=downloads&colorB=green&suffix=/day&query=$.downloads&uri=https://api.npmjs.org//downloads/point/last-day/eslint-plugin-svelte&maxAge=3600)](http://www.npmtrends.com/eslint-plugin-svelte)
@@ -46,6 +44,13 @@ We are working on support for Svelte v5, but it is still an experimental feature
 
 <!--DOCS_IGNORE_START-->
 
+## Versioning policy
+
+This plugin follows [Semantic Versioning](https://semver.org/).  
+However, unlike [ESLint’s Semantic Versioning Policy](https://github.com/eslint/eslint#semantic-versioning-policy), this plugin adds new rules to its configs even in minor releases. For example, if you are using the recommended config, a minor update may add new rules, which could cause new lint errors in your project.  
+While [ESLint’s Semantic Versioning Policy](https://github.com/eslint/eslint#semantic-versioning-policy) only adds new rules to configs in major releases, most users (myself included) don’t regularly monitor new rules. This makes it challenging to manually add them to projects whenever they are introduced.  
+By adding new rules to configs in minor releases, this plugin ensures users can adopt them more easily. If any new rules cause issues, you can simply disable them. I believe this approach helps maintain and improve code quality with minimal effort.
+
 ## Migration Guide
 
 To migrate from `eslint-plugin-svelte` v1, or [`@ota-meshi/eslint-plugin-svelte`](https://www.npmjs.com/package/@ota-meshi/eslint-plugin-svelte), please refer to the [migration guide](https://sveltejs.github.io/eslint-plugin-svelte/migration/).

docs/README.md

@@ -14,8 +14,6 @@ You can check on the [Online DEMO](https://eslint-online-playground.netlify.app/
 > For example, <https://github.com/sveltejs/eslint-plugin-svelte/blob/eslint-plugin-svelte%402.46.0/README.md>
 > and <https://github.com/sveltejs/eslint-plugin-svelte/blob/eslint-plugin-svelte%402.46.0/docs>
 
-**_We are working on experimental support for Svelte v5, but may break with new versions of Svelte v5._**
-
 [![NPM license](https://img.shields.io/npm/l/eslint-plugin-svelte.svg)](https://www.npmjs.com/package/eslint-plugin-svelte)
 [![NPM version](https://img.shields.io/npm/v/eslint-plugin-svelte.svg)](https://www.npmjs.com/package/eslint-plugin-svelte)
 [![NPM downloads](https://img.shields.io/badge/dynamic/json.svg?label=downloads&colorB=green&suffix=/day&query=$.downloads&uri=https://api.npmjs.org//downloads/point/last-day/eslint-plugin-svelte&maxAge=3600)](http://www.npmtrends.com/eslint-plugin-svelte)

package.json

@@ -4,7 +4,7 @@
   "private": true,
   "license": "MIT",
   "funding": "https://github.com/sponsors/ota-meshi",
-  "packageManager": "pnpm@9.14.4",
+  "packageManager": "pnpm@9.15.2",
   "scripts": {
     "prerelease": "cd packages/eslint-plugin-svelte && pnpm clean && pnpm run build && cd ../.. && cp README.md packages/eslint-plugin-svelte",
     "release": "changeset publish",
@@ -24,7 +24,7 @@
     "@typescript-eslint/parser": "^8.16.0",
     "c8": "^10.1.2",
     "env-cmd": "^10.1.0",
-    "eslint": "~9.16.0",
+    "eslint": "~9.17.0",
     "eslint-config-prettier": "^9.1.0",
     "eslint-formatter-friendly": "^7.0.0",
     "eslint-plugin-eslint-plugin": "^6.3.2",

packages/eslint-plugin-svelte/CHANGELOG.md

@@ -1,5 +1,11 @@
 # eslint-plugin-svelte
 
+## 3.0.0-next.5
+
+### Patch Changes
+
+- [#956](https://github.com/sveltejs/eslint-plugin-svelte/pull/956) [`157ee1f`](https://github.com/sveltejs/eslint-plugin-svelte/commit/157ee1fade79aab88f01d125b0b01cf375da4cd1) Thanks [@baseballyama](https://github.com/baseballyama)! - chore: update `svelte-eslint-parser` to v1.0.0-next.4
+
 ## 3.0.0-next.4
 
 ### Major Changes

packages/eslint-plugin-svelte/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-svelte",
-  "version": "3.0.0-next.4",
+  "version": "3.0.0-next.5",
   "description": "ESLint plugin for Svelte using AST",
   "repository": "git+https://github.com/sveltejs/eslint-plugin-svelte.git",
   "homepage": "https://sveltejs.github.io/eslint-plugin-svelte",
@@ -30,7 +30,7 @@
     "cover": "c8 --reporter=lcov pnpm run test",
     "debug": "pnpm run mocha \"tests/src/**/*.ts\" --reporter dot --timeout 60000",
     "lint": "run-p lint:*",
-    "lint-fix": "pnpm run lint:es --fix && pnpm run lint:style --fix",
+    "lint-fix": "pnpm run lint:es --fix",
     "lint:es": "eslint --cache .",
     "mocha": "pnpm run ts ./node_modules/mocha/bin/mocha.js",
     "new": "pnpm run ts ./tools/new-rule.ts",
@@ -63,10 +63,10 @@
     "known-css-properties": "^0.35.0",
     "postcss": "^8.4.49",
     "postcss-load-config": "^3.1.4",
-    "postcss-safe-parser": "^6.0.0",
+    "postcss-safe-parser": "^7.0.0",
     "postcss-selector-parser": "^7.0.0",
     "semver": "^7.6.3",
-    "svelte-eslint-parser": "^1.0.0-next.3"
+    "svelte-eslint-parser": "^1.0.0-next.4"
   },
   "devDependencies": {
     "@babel/core": "^7.26.0",
@@ -91,7 +91,7 @@
     "eslint-visitor-keys": "^4.2.0",
     "espree": "^10.3.0",
     "less": "^4.2.1",
-    "mocha": "^10.8.2",
+    "mocha": "^11.0.0",
     "postcss-nested": "^7.0.2",
     "sass": "^1.81.0",
     "source-map-js": "^1.2.1",

packages/eslint-plugin-svelte/src/meta.ts

@@ -2,4 +2,4 @@
 // This file has been automatically generated,
 // in order to update its content execute "pnpm run update"
 export const name = 'eslint-plugin-svelte';
-export const version = '3.0.0-next.4';
+export const version = '3.0.0-next.5';

packages/eslint-plugin-svelte/src/rules/indent-helpers/svelte.ts

@@ -289,7 +289,9 @@ export function defineVisitor(context: IndentContext): NodeListener {
 				const closeOpenTagToken = sourceCode.getTokenAfter(key.lastToken);
 				offsets.setOffsetToken(closeOpenTagToken, 0, openToken);
 			} else {
-				const closeOpenTagToken = sourceCode.getTokenAfter(node.index || node.context);
+				const closeOpenTagToken = sourceCode.getTokenAfter(
+					node.index || node.context || node.expression
+				);
 				offsets.setOffsetToken(closeOpenTagToken, 0, openToken);
 			}
 

packages/eslint-plugin-svelte/src/rules/mustache-spacing.ts

@@ -272,7 +272,7 @@ export default createRule('mustache-spacing', {
 			SvelteEachBlock(node: AST.SvelteEachBlock) {
 				const openBlockOpeningToken = sourceCode.getFirstToken(node);
 				const openBlockClosingToken = sourceCode.getTokenAfter(
-					node.key || node.index || node.context,
+					node.key || node.index || node.context || node.expression,
 					{
 						includeComments: false,
 						filter: isClosingBraceToken

packages/eslint-plugin-svelte/src/rules/no-immutable-reactive-statements.ts

@@ -135,7 +135,9 @@ export default createRule('no-immutable-reactive-statements', {
 				return parent.kind === 'Binding' && parent.expression === expr;
 			}
 			if (parent.type === 'SvelteEachBlock') {
-				return parent.expression === expr && hasWriteReference(parent.context);
+				return (
+					parent.context !== null && parent.expression === expr && hasWriteReference(parent.context)
+				);
 			}
 
 			return false;

packages/eslint-plugin-svelte/src/rules/require-each-key.ts

@@ -15,7 +15,9 @@ export default createRule('require-each-key', {
 	create(context) {
 		return {
 			SvelteEachBlock(node: AST.SvelteEachBlock) {
-				if (node.key == null) {
+				// No need a `key` if an each blocks without an item
+				// see: https://svelte.dev/docs/svelte/each#Each-blocks-without-an-item
+				if (node.context != null && node.key == null) {
 					context.report({
 						node,
 						messageId: 'expectedKey'

packages/eslint-plugin-svelte/src/rules/valid-each-key.ts

@@ -27,11 +27,15 @@ export default createRule('valid-each-key', {
 					if (
 						!variable.defs.some(
 							(def) =>
-								(node.context.range[0] <= def.name.range[0] &&
+								(node.context &&
+									node.context.range[0] <= def.name.range[0] &&
 									def.name.range[1] <= node.context.range[1]) ||
 								(node.index &&
 									node.index.range[0] <= def.name.range[0] &&
-									def.name.range[1] <= node.index.range[1])
+									def.name.range[1] <= node.index.range[1]) ||
+								(node.expression &&
+									node.expression.range[0] <= def.name.range[0] &&
+									def.name.range[1] <= node.expression.range[1])
 						)
 					) {
 						// It's not an iteration variable.

packages/eslint-plugin-svelte/src/rules/valid-prop-names-in-kit-pages.ts

@@ -2,9 +2,27 @@ import type { AST } from 'svelte-eslint-parser';
 import type { TSESTree } from '@typescript-eslint/types';
 import { createRule } from '../utils/index.js';
 import { isKitPageComponent } from '../utils/svelte-kit.js';
+import type { RuleContext } from '../types.js';
 
 const EXPECTED_PROP_NAMES = ['data', 'errors', 'form', 'snapshot'];
 
+function checkProp(node: TSESTree.VariableDeclarator, context: RuleContext) {
+	if (node.id.type !== 'ObjectPattern') return;
+	for (const p of node.id.properties) {
+		if (
+			p.type === 'Property' &&
+			p.value.type === 'Identifier' &&
+			!EXPECTED_PROP_NAMES.includes(p.value.name)
+		) {
+			context.report({
+				node: p.value,
+				loc: p.value.loc,
+				messageId: 'unexpected'
+			});
+		}
+	}
+}
+
 export default createRule('valid-prop-names-in-kit-pages', {
 	meta: {
 		docs: {
@@ -39,6 +57,7 @@ export default createRule('valid-prop-names-in-kit-pages', {
 				isScript = false;
 			},
 
+			// Svelte3,4
 			'ExportNamedDeclaration > VariableDeclaration > VariableDeclarator': (
 				node: TSESTree.VariableDeclarator
 			) => {
@@ -57,20 +76,22 @@ export default createRule('valid-prop-names-in-kit-pages', {
 				}
 
 				// export let { xxx, yyy } = zzz
-				if (node.id.type !== 'ObjectPattern') return;
-				for (const p of node.id.properties) {
-					if (
-						p.type === 'Property' &&
-						p.value.type === 'Identifier' &&
-						!EXPECTED_PROP_NAMES.includes(p.value.name)
-					) {
-						context.report({
-							node: p.value,
-							loc: p.value.loc,
-							messageId: 'unexpected'
-						});
-					}
+				checkProp(node, context);
+			},
+
+			// Svelte5
+			// let { foo, bar } = $props();
+			'VariableDeclaration > VariableDeclarator': (node: TSESTree.VariableDeclarator) => {
+				if (!isScript) return;
+				if (
+					node.init?.type !== 'CallExpression' ||
+					node.init.callee?.type !== 'Identifier' ||
+					node.init.callee?.name !== '$props'
+				) {
+					return;
 				}
+
+				checkProp(node, context);
 			}
 		};
 	}

packages/eslint-plugin-svelte/tests/fixtures/rules/require-each-key/valid/svelte5/_requirements.json

@@ -0,0 +1,3 @@
+{
+	"svelte": ">=5.0.0-0"
+}

packages/eslint-plugin-svelte/tests/fixtures/rules/require-each-key/valid/svelte5/each-blocks-without-an-item-input.svelte

@@ -0,0 +1,7 @@
+<div class="chess-board">
+	{#each { length: 8 }, rank}
+		{#each { length: 8 }}
+			{rank}
+		{/each}
+	{/each}
+</div>

packages/eslint-plugin-svelte/tests/fixtures/rules/valid-compile/invalid/a11y01-errors.yaml

@@ -1,4 +1,6 @@
-- message: '`<img>` element should have an alt attribute(a11y_missing_attribute)'
+- message: |-
+    `<img>` element should have an alt attribute
+    https://svelte.dev/e/a11y_missing_attribute(a11y_missing_attribute)
   line: 5
   column: 1
   suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore01-errors.yaml

@@ -1,15 +1,18 @@
-- message: noninteractive element cannot have nonnegative tabIndex
-    value(a11y_no_noninteractive_tabindex)
+- message: |-
+    noninteractive element cannot have nonnegative tabIndex value
+    https://svelte.dev/e/a11y_no_noninteractive_tabindex(a11y_no_noninteractive_tabindex)
   line: 6
   column: 3
   suggestions: null
-- message: A form label must be associated with a
-    control(a11y_label_has_associated_control)
+- message: |-
+    A form label must be associated with a control
+    https://svelte.dev/e/a11y_label_has_associated_control(a11y_label_has_associated_control)
   line: 6
   column: 3
   suggestions: null
-- message: noninteractive element cannot have nonnegative tabIndex
-    value(a11y_no_noninteractive_tabindex)
+- message: |-
+    noninteractive element cannot have nonnegative tabIndex value
+    https://svelte.dev/e/a11y_no_noninteractive_tabindex(a11y_no_noninteractive_tabindex)
   line: 7
   column: 3
   suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore01-svelte4-errors.yaml

@@ -3,8 +3,7 @@
   line: 6
   column: 3
   suggestions: null
-- message: 'A11y: A form label must be associated with a
-    control.(a11y-label-has-associated-control)'
+- message: 'A11y: A form label must be associated with a control.(a11y-label-has-associated-control)'
   line: 6
   column: 3
   suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/valid-compile/invalid/invalid-svelte-ignore02-errors.yaml

@@ -1,15 +1,18 @@
-- message: noninteractive element cannot have nonnegative tabIndex
-    value(a11y_no_noninteractive_tabindex)
+- message: |-
+    noninteractive element cannot have nonnegative tabIndex value
+    https://svelte.dev/e/a11y_no_noninteractive_tabindex(a11y_no_noninteractive_tabindex)
   line: 6
   column: 3
   suggestions: null
-- message: A form label must be associated with a
-    control(a11y_label_has_associated_control)
+- message: |-
+    A form label must be associated with a control
+    https://svelte.dev/e/a11y_label_has_associated_control(a11y_label_has_associated_control)
   line: 6
   column: 3
   suggestions: null
-- message: noninteractive element cannot have nonnegative tabIndex
-    value(a11y_no_noninteractive_tabindex)
+- message: |-
+    noninteractive element cannot have nonnegative tabIndex value
+    https://svelte.dev/e/a11y_no_noninteractive_tabindex(a11y_no_noninteractive_tabindex)
   line: 7
   column: 3
   suggestions: null