chore: add bind tests for no-unnecessary-state-wrap (#1181)

Author: baseballyama

packages/eslint-plugin-svelte/src/rules/no-unnecessary-state-wrap.ts

@@ -53,8 +53,12 @@ export default createRule('no-unnecessary-state-wrap', {
 		const options = context.options[0] ?? {};
 		const additionalReactiveClasses = options.additionalReactiveClasses ?? [];
 		const allowReassign = options.allowReassign ?? false;
+		const { globalScope } = context.sourceCode.scopeManager;
+		if (globalScope == null) {
+			return {};
+		}
 
-		const referenceTracker = new ReferenceTracker(context.sourceCode.scopeManager.globalScope!);
+		const referenceTracker = new ReferenceTracker(globalScope);
 		const traceMap: Record<string, Record<string, boolean>> = {};
 		for (const reactiveClass of REACTIVE_CLASSES) {
 			traceMap[reactiveClass] = {
@@ -79,8 +83,10 @@ export default createRule('no-unnecessary-state-wrap', {
 		});
 
 		function isReassigned(identifier: TSESTree.Identifier): boolean {
-			const variable = context.sourceCode.scopeManager.getDeclaredVariables(identifier.parent)[0];
-			return variable.references.some((ref) => {
+			const references = context.sourceCode.scopeManager
+				.getDeclaredVariables(identifier.parent)
+				.flatMap((v) => v.references);
+			return references.some((ref) => {
 				return ref.isWrite() && ref.identifier !== identifier;
 			});
 		}

packages/eslint-plugin-svelte/tests/fixtures/rules/no-unnecessary-state-wrap/valid/allow-reassign-bind1-config.json

@@ -0,0 +1,7 @@
+{
+	"options": [
+		{
+			"allowReassign": true
+		}
+	]
+}

packages/eslint-plugin-svelte/tests/fixtures/rules/no-unnecessary-state-wrap/valid/allow-reassign-bind1-input.svelte

@@ -0,0 +1,8 @@
+<script lang="ts">
+	import { SvelteSet } from 'svelte/reactivity';
+	import Bug3 from './Bug3.svelte';
+
+	let svelteSet = $state(new SvelteSet<number>([]));
+</script>
+
+<Bug3 bind:svelteSet />

packages/eslint-plugin-svelte/tests/fixtures/rules/no-unnecessary-state-wrap/valid/allow-reassign-bind2-config.json

@@ -0,0 +1,7 @@
+{
+	"options": [
+		{
+			"allowReassign": true
+		}
+	]
+}

packages/eslint-plugin-svelte/tests/fixtures/rules/no-unnecessary-state-wrap/valid/allow-reassign-bind2-input.svelte

@@ -0,0 +1,8 @@
+<script lang="ts">
+	import { SvelteSet } from 'svelte/reactivity';
+	import Bug3 from './Bug3.svelte';
+
+	let svelteSet = $state(new SvelteSet<number>([]));
+</script>
+
+<Bug3 bind:svelteSet={() => svelteSet, (v) => (svelteSet = v)} />