This repository was archived by the owner on Dec 30, 2023. It is now read-only.
Fixes & optimizations #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XXX the at() members of PointCloud[T] can also throw: >>> a = np.random.randn(10000, 3).astype(np.float32) >>> p = PointCloud() >>> p.from_array(a) >>> p[10000] terminate called after throwing an instance of 'std::out_of_range' what(): vector::_M_range_check Aborted ... but a bug in Cython's code generator prevents "except+" from working with a function returning a reference.
Using pointers to work around broken C++ reference support in Cython. operator[] seems to be completely broken in Cython. E.g. >>> a = np.random.randn(10000, 3).astype(np.float32) >>> p = PointCloud() >>> p.from_array(a) >>> %timeit p.to_array() 10000 loops, best of 3: 23.4 µs per loop Previously 50.8 µs per loop.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some fixes for type-safety and exception safety, as well as some small optimizations. See the commit messages for details.