From 595929828f79b02deb9d9372ade0a78ef666b687 Mon Sep 17 00:00:00 2001 From: DhruvArvindSingh Date: Mon, 6 Jan 2025 21:58:23 +0000 Subject: [PATCH 1/2] refactor: update math/base/assert/is-infinitef native addon from C++ to C --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- .../base/assert/is-infinitef/include.gypi | 2 +- .../base/assert/is-infinitef/manifest.json | 108 ++++++++++++------ .../math/base/assert/is-infinitef/src/addon.c | 41 +++++++ .../base/assert/is-infinitef/src/addon.cpp | 80 ------------- .../assert/is-infinitef/test/test.native.js | 24 ---- 5 files changed, 112 insertions(+), 143 deletions(-) create mode 100644 lib/node_modules/@stdlib/math/base/assert/is-infinitef/src/addon.c delete mode 100644 lib/node_modules/@stdlib/math/base/assert/is-infinitef/src/addon.cpp diff --git a/lib/node_modules/@stdlib/math/base/assert/is-infinitef/include.gypi b/lib/node_modules/@stdlib/math/base/assert/is-infinitef/include.gypi index ffd7702dc420..de5f9994b817 100644 --- a/lib/node_modules/@stdlib/math/base/assert/is-infinitef/include.gypi +++ b/lib/node_modules/@stdlib/math/base/assert/is-infinitef/include.gypi @@ -36,7 +36,7 @@ # Source files: 'src_files': [ - '<(src_dir)/addon.cpp', + '<(src_dir)/addon.c', ' +#include + +/** +* Receives JavaScript callback invocation data. +* +* @param env environment under which the function is invoked +* @param info callback data +* @return Node-API value +*/ +static napi_value addon( napi_env env, napi_callback_info info ) { + STDLIB_NAPI_ARGV( env, info, argv, argc, 1 ); + STDLIB_NAPI_ARGV_FLOAT( env, x, argv, 0 ); + STDLIB_NAPI_CREATE_INT32( env, stdlib_base_is_infinitef( x ), out ); + return out; +} + +STDLIB_NAPI_MODULE_EXPORT_FCN( addon ) diff --git a/lib/node_modules/@stdlib/math/base/assert/is-infinitef/src/addon.cpp b/lib/node_modules/@stdlib/math/base/assert/is-infinitef/src/addon.cpp deleted file mode 100644 index 241aff36eae5..000000000000 --- a/lib/node_modules/@stdlib/math/base/assert/is-infinitef/src/addon.cpp +++ /dev/null @@ -1,80 +0,0 @@ -/** -* @license Apache-2.0 -* -* Copyright (c) 2020 The Stdlib Authors. -* -* Licensed under the Apache License, Version 2.0 (the "License"); -* you may not use this file except in compliance with the License. -* You may obtain a copy of the License at -* -* http://www.apache.org/licenses/LICENSE-2.0 -* -* Unless required by applicable law or agreed to in writing, software -* distributed under the License is distributed on an "AS IS" BASIS, -* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -* See the License for the specific language governing permissions and -* limitations under the License. -*/ - -#include "stdlib/math/base/assert/is_infinitef.h" -#include -#include -#include - -/** -* Add-on namespace. -*/ -namespace stdlib_math_base_assert_is_infinitef { - - /** - * Tests if a single-precision floating-point numeric value is infinite. - * - * ## Notes - * - * - When called from JavaScript, the function expects one argument: - * - * - `x`: a number - */ - napi_value node_is_infinitef( napi_env env, napi_callback_info info ) { - napi_status status; - - size_t argc = 1; - napi_value argv[ 1 ]; - status = napi_get_cb_info( env, info, &argc, argv, nullptr, nullptr ); - assert( status == napi_ok ); - - if ( argc < 1 ) { - napi_throw_error( env, nullptr, "invalid invocation. Must provide a number." ); - return nullptr; - } - - napi_valuetype vtype0; - status = napi_typeof( env, argv[ 0 ], &vtype0 ); - assert( status == napi_ok ); - - napi_value v; - double x; - if ( vtype0 == napi_number ) { - status = napi_get_value_double( env, argv[ 0 ], &x ); - assert( status == napi_ok ); - - status = napi_create_int32( env, (int32_t)stdlib_base_is_infinitef( (float)x ), &v ); - assert( status == napi_ok ); - } else { - status = napi_create_int32( env, 0, &v ); - assert( status == napi_ok ); - } - - return v; - } - - napi_value Init( napi_env env, napi_value exports ) { - napi_status status; - napi_value fcn; - status = napi_create_function( env, "exports", NAPI_AUTO_LENGTH, node_is_infinitef, NULL, &fcn ); - assert( status == napi_ok ); - return fcn; - } - - NAPI_MODULE( NODE_GYP_MODULE_NAME, Init ) -} // end namespace stdlib_math_base_assert_is_infinitef diff --git a/lib/node_modules/@stdlib/math/base/assert/is-infinitef/test/test.native.js b/lib/node_modules/@stdlib/math/base/assert/is-infinitef/test/test.native.js index 5c910def3616..10956148a015 100644 --- a/lib/node_modules/@stdlib/math/base/assert/is-infinitef/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/assert/is-infinitef/test/test.native.js @@ -52,27 +52,3 @@ tape( 'the function returns `true` if provided `-infinity`', opts, function test t.equal( isInfinitef( NINF ), true, 'returns true' ); t.end(); }); - -tape( 'the function returns `false` if not provided an infinite number', opts, function test( t ) { - var values; - var i; - - values = [ - '5', - 5.0, - -1.0e38, - 4.0e-38, - NaN, - true, - null, - void 0, - [], - {}, - function noop() {} - ]; - - for ( i = 0; i < values.length; i++ ) { - t.equal( isInfinitef( values[i] ), false, 'returns false' ); - } - t.end(); -}); From cea7abc940a9fd75597dfc7a2af6fd06b45639f0 Mon Sep 17 00:00:00 2001 From: Dhruv/ <154677013+DhruvArvindSingh@users.noreply.github.com> Date: Sat, 18 Jan 2025 17:25:13 +0530 Subject: [PATCH 2/2] Update lib/node_modules/@stdlib/math/base/assert/is-infinitef/src/addon.c Co-authored-by: Athan Signed-off-by: Dhruv/ <154677013+DhruvArvindSingh@users.noreply.github.com> --- .../@stdlib/math/base/assert/is-infinitef/src/addon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node_modules/@stdlib/math/base/assert/is-infinitef/src/addon.c b/lib/node_modules/@stdlib/math/base/assert/is-infinitef/src/addon.c index 7cd1ca29cdb9..e984c85d17b2 100644 --- a/lib/node_modules/@stdlib/math/base/assert/is-infinitef/src/addon.c +++ b/lib/node_modules/@stdlib/math/base/assert/is-infinitef/src/addon.c @@ -34,7 +34,7 @@ static napi_value addon( napi_env env, napi_callback_info info ) { STDLIB_NAPI_ARGV( env, info, argv, argc, 1 ); STDLIB_NAPI_ARGV_FLOAT( env, x, argv, 0 ); - STDLIB_NAPI_CREATE_INT32( env, stdlib_base_is_infinitef( x ), out ); + STDLIB_NAPI_CREATE_INT32( env, (int32_t)stdlib_base_is_infinitef( x ), out ); return out; }