Skip to content

Conversation

@jonas-hurst
Copy link
Contributor

@jonas-hurst jonas-hurst commented Apr 2, 2025

Related Issue(s):

Description:
Adds the STAC:MLM extension: https://github.com/stac-extensions/mlm

PR Checklist:

  • Pre-commit hooks pass (run pre-commit run --all-files)
  • Tests pass (run pytest)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@jonas-hurst jonas-hurst marked this pull request as draft April 2, 2025 13:23
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 99.48849% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.35%. Comparing base (e713adf) to head (477f5f9).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
pystac/extensions/mlm.py 99.47% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1542      +/-   ##
==========================================
+ Coverage   91.62%   92.35%   +0.73%     
==========================================
  Files          54       55       +1     
  Lines        7578     8360     +782     
  Branches      923      960      +37     
==========================================
+ Hits         6943     7721     +778     
- Misses        451      453       +2     
- Partials      184      186       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonas-hurst jonas-hurst marked this pull request as ready for review April 3, 2025 13:15
@jonas-hurst jonas-hurst marked this pull request as draft April 3, 2025 13:17
@jonas-hurst jonas-hurst marked this pull request as ready for review April 3, 2025 13:37
@gadomski gadomski self-requested a review April 7, 2025 13:17
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Some minor tweaks requested, mostly spelling.

@jonas-hurst jonas-hurst requested a review from gadomski April 15, 2025 09:05
@gadomski gadomski enabled auto-merge April 15, 2025 13:57
@gadomski gadomski added this pull request to the merge queue Apr 15, 2025
Merged via the queue into stac-utils:main with commit 9351385 Apr 15, 2025
19 checks passed
fmigneault added a commit to stac-extensions/mlm that referenced this pull request Apr 15, 2025
- Add `pystac.extensions.mlm` reference (relates to stac-utils/pystac#1542)
- Update listing of resources with more details and formatting
@fmigneault
Copy link
Contributor

Thanks for the integration.
Let us know when the new version is released.
I will cross-reference it in the MLM repository (see stac-extensions/mlm#85).

@gadomski
Copy link
Member

Will do! I'm going to try to squeeze in #1549 and then cut a v1.13

@gadomski
Copy link
Member

kmodali pushed a commit to kmodali/pystac that referenced this pull request Oct 16, 2025
* added missing Classification parameter title

* added changes to changelog

* added missing parameters to test_classification_object: title, nodata, percentage, count

* added ml extension

* added stac:mlm extension tests

* added collection and asset extension

* removed TODO

* added documentation

* added docstring to classes

* renamed asset extension classes

* added mlm extension classes

* added mlm extension

* removed todos

* added extension migration

* removed useless code

* fixed docstrings

* fixed __eq__ NotImplemented

* fixed repr strings

* improved test coverage

* improved test coverage

* changed exceptions

* fixed docstring

* Update CHANGELOG.md

Co-authored-by: Pete Gadomski <[email protected]>

* fixed typo

Co-authored-by: Pete Gadomski <[email protected]>

* fixed typo

Co-authored-by: Pete Gadomski <[email protected]>

* fixed typo

Co-authored-by: Pete Gadomski <[email protected]>

* fixed typo

Co-authored-by: Pete Gadomski <[email protected]>

* fixed typo

Co-authored-by: Pete Gadomski <[email protected]>

* line break to satisfy line length requirement

* fixed typo in ENTRYPOINT_ASSET_PROP

* fixed typo in COMPILE_METHOD_ASSET_PROP

* removed dummy docstring

* fixed Enum tuples

* added mlm to CollectionExt

* added mlm to Asset and ItemAssetDefinition mlm accessor

* Update CHANGELOG.md

---------

Co-authored-by: Pete Gadomski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for stac:mlm extension

3 participants