Fix get_items without ids
#579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing empty list to `search` has different semantics than `None`.
gadomski
force-pushed
the
fix-get-items-without-ids
branch
from
a1742ef to
8a1e69f
Compare
jsignell
approved these changes
Aug 21, 2023
Member
jsignell
left a comment
jsignell
left a comment
There was a problem hiding this comment.
This is fine, but maybe it should be handled in the .search method itself?
Member
Author
Good point. The spec doesn't call out expected behavior w.r.t. missing vs empty, but as it seems nonsensical to say "search but don't return any items", moving it to |
gadomski
commented
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Passing empty list to
searchhas different semantics thanNone. Discovered when updating cassettes for a v0.7.3 release, so 👍🏼 for having "update cassettes" part of the release process.PR Checklist: