Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

Commit 08b8c74

Browse files
committed
Remove a cachePut that was adding FSObject to cache, which triggered out-of-memory errors. This code path was never previously triggered for filesystem-based storage.
Signed-off-by: Filip Navara <[email protected]>
1 parent 12f3027 commit 08b8c74

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

plumbing/format/packfile/packfile.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ func (p *Packfile) GetByOffset(o int64) (plumbing.EncodedObject, error) {
7979
}
8080
}
8181

82-
return p.objectAtOffset(o);
82+
return p.objectAtOffset(o)
8383
}
8484

8585
func (p *Packfile) objectHeaderAtOffset(offset int64) (*ObjectHeader, error) {
@@ -208,7 +208,7 @@ func (p *Packfile) objectAtOffset(offset int64) (plumbing.EncodedObject, error)
208208

209209
// If we have no filesystem, we will return a MemoryObject instead
210210
// of an FSObject.
211-
if p.fs == nil || h.Length <= 16 * 1024 {
211+
if p.fs == nil || h.Length <= 16*1024 {
212212
return p.getNextObject(h)
213213
}
214214

@@ -347,8 +347,6 @@ func (p *Packfile) fillOFSDeltaObjectContent(obj plumbing.EncodedObject, offset
347347
if err != nil {
348348
return err
349349
}
350-
351-
p.cachePut(base)
352350
}
353351

354352
obj.SetType(base.Type())

0 commit comments

Comments
 (0)