Fix environmentDidChange

Author: n8chur

ViewEnvironmentUI/Sources/UIView+ViewEnvironmentPropagatingObject.swift

@@ -29,10 +29,6 @@ extension UIView: ViewEnvironmentPropagatingObject {
     @_spi(ViewEnvironmentWiring)
     public func setNeedsApplyEnvironment() {
         setNeedsLayout()
-
-        if let observing = self as? ViewEnvironmentObserving {
-            observing.environmentDidChange()
-        }
     }
 }
 

ViewEnvironmentUI/Sources/UIViewController+ViewEnvironmentPropagatingObject.swift

@@ -37,10 +37,6 @@ extension UIViewController: ViewEnvironmentPropagatingObject {
     @_spi(ViewEnvironmentWiring)
     public func setNeedsApplyEnvironment() {
         viewIfLoaded?.setNeedsLayout()
-
-        if let observing = self as? ViewEnvironmentObserving {
-            observing.environmentDidChange()
-        }
     }
 }
 

ViewEnvironmentUI/Sources/ViewEnvironmentPropagating.swift

@@ -137,7 +137,9 @@ extension ViewEnvironmentPropagating {
             // If the descendant's ancestor is nil it has opted out of environment updates and is likely acting as
             // a root for propagation bridging purposes (e.g. from a Workflow ViewEnvironment update).
             // Avoid updating the descendant if this is the case.
-            guard descendant.environmentAncestor != nil else { continue }
+            guard descendant.environmentAncestor != nil else {
+                continue
+            }
 
             descendant.setNeedsEnvironmentUpdate()
         }

ViewEnvironmentUI/Sources/ViewEnvironmentPropagatingObject.swift

@@ -214,6 +214,10 @@ extension ViewEnvironmentPropagatingObject {
     public func setNeedsEnvironmentUpdate() {
         needsEnvironmentUpdate = true
 
+        if let observing = self as? ViewEnvironmentObserving {
+            observing.environmentDidChange()
+        }
+
         if !needsUpdateObservers.isEmpty {
             let environment = self.environment
 

ViewEnvironmentUI/Sources/ViewEnvironmentPropagationNode.swift

@@ -74,6 +74,8 @@ public class ViewEnvironmentPropagationNode: ViewEnvironmentCustomizing, ViewEnv
     public func setNeedsEnvironmentUpdate() {
         needsEnvironmentUpdate = true
 
+        environmentDidChange()
+
         setNeedsEnvironmentUpdateOnAppropriateDescendants()
     }