Skip to content

Better Log.e() usage #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
commonsguy opened this issue Sep 12, 2012 · 2 comments
Closed

Better Log.e() usage #65

commonsguy opened this issue Sep 12, 2012 · 2 comments
Labels
enhancement A software enhancement for SQLCipher for Android

Comments

@commonsguy
Copy link
Collaborator

Instead of lines like:

Log.e(TAG, "Error copying icu data file" + e.getMessage());

I recommend:

Log.e(TAG, "Error copying icu data file", e);

This has two advantages:

  1. The entire stack trace for the exception will be logged, which is useful for figuring out the precise nature of the problem (particularly since getMessage() is often not helpful).
  2. It is less typing. :-)
@developernotes
Copy link
Member

Hi Mark,

That's a good catch, I'll make the adjustment. Thanks!

@developernotes
Copy link
Member

This change has been made fixed in 22b1151.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A software enhancement for SQLCipher for Android
Projects
None yet
Development

No branches or pull requests

2 participants