From a0fd6d98e09111272017c02f7623f06be5e0ad46 Mon Sep 17 00:00:00 2001 From: Andrew Benton Date: Tue, 18 Apr 2023 15:39:33 -0700 Subject: [PATCH] Avoid some unnecessary buffering when reading config file --- internal/cmd/generate.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/internal/cmd/generate.go b/internal/cmd/generate.go index b828c21193..1d68643f48 100644 --- a/internal/cmd/generate.go +++ b/internal/cmd/generate.go @@ -100,13 +100,14 @@ func readConfig(stderr io.Writer, dir, filename string) (string, *config.Config, } base := filepath.Base(configPath) - blob, err := os.ReadFile(configPath) + file, err := os.Open(configPath) if err != nil { fmt.Fprintf(stderr, "error parsing %s: file does not exist\n", base) return "", nil, err } + defer file.Close() - conf, err := config.ParseConfig(bytes.NewReader(blob)) + conf, err := config.ParseConfig(file) if err != nil { switch err { case config.ErrMissingVersion: