Skip to content

Consider making Session implementations public #2258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
marcusdacoregio opened this issue Mar 15, 2023 · 1 comment
Open

Consider making Session implementations public #2258

marcusdacoregio opened this issue Mar 15, 2023 · 1 comment
Assignees
@marcusdacoregio
Labels
for: team-attention This ticket should be discussed as a team before proceeding in: jdbc in: mongo-db in: redis type: enhancement A general enhancement

Comments

@marcusdacoregio
Copy link
Contributor

marcusdacoregio commented Mar 15, 2023 •
edited
Loading

Expected Behavior

It should be possible to extend or delegate to those implementations.

Current Behavior

  • SessionRepository implementations are open for extension but cannot be extended, e.g. there is no way to override createSession or save methods.
  • This issue mentions that the MongoSession is an internal implementation detail of the MongoIndexedSessionRepository implementation. That actually is not 100% true since MongoSession is returned by the API.
  • The AbstractMongoSessionConverter is meant to be extended accordingly to its javadoc, but it is not possible since its abstract methods work with MongoSession and that implementation is package-private
  • Since each implementation is part of the public API, it is strange that they are not public

Context
@marcusdacoregio marcusdacoregio added type: enhancement A general enhancement in: redis in: mongo-db in: jdbc for: team-attention This ticket should be discussed as a team before proceeding labels Mar 15, 2023
@marcusdacoregio marcusdacoregio self-assigned this Mar 15, 2023
@quaff quaff mentioned this issue Mar 29, 2023
Closed
@marcusdacoregio marcusdacoregio mentioned this issue Aug 8, 2023
Closed
@marcusdacoregio marcusdacoregio mentioned this issue Oct 30, 2023
Closed
@Survival1sm
Copy link

Survival1sm commented May 14, 2024 •
edited
Loading

#2217 mentions this enhancement would be in 3.3 scheduled for this May, are we still on track to hit this goal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
for: team-attention This ticket should be discussed as a team before proceeding in: jdbc in: mongo-db in: redis type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcusdacoregio @Survival1sm