Skip to content

Increase visibility of RedisSession inner class in order to write custom behavior #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Stoony opened this issue Dec 9, 2019 · 3 comments
Assignees

Comments

@Stoony
Copy link

Stoony commented Dec 9, 2019

Hi,

I'm facing some issues with the default behavior of the spring-session-data-redis module which doesn't manage redis unavailability with a fallback strategy for example. I need to extend the RedisIndexedSessionRepository class in order to implement the desired behavior but I can't achieve this because some methods (save) signature use the RedisSession type and this one has got a package visibility only.

I also need to override the SessionRepositoryFilter class which requires the RedisSession type to be given as generic argument and led to the same issue.

Is it possible to set the visibility of the class RedisSession to public so we can use a custom implementation of the session repository staying with the use of standard annotations and session object to enable redis http session.

Thank by advance for considering this problem, I'd like to avoid to duplicate the entire module in my app to write the needed features.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 9, 2019
@eleftherias
Copy link
Contributor

@Stoony Could you use composition instead of inheritance?
For more details and examples take a look at these issues: #1217 and #849.

@eleftherias eleftherias self-assigned this Jan 2, 2020
@eleftherias eleftherias added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 2, 2020
@spring-projects-issues
Copy link

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues spring-projects-issues added the status: feedback-reminder We've sent a reminder that we need additional information before we can continue label Jan 9, 2020
@spring-projects-issues
Copy link

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

@spring-projects-issues spring-projects-issues removed status: waiting-for-feedback We need additional information before we can continue status: feedback-reminder We've sent a reminder that we need additional information before we can continue labels Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants