JdbcOperationsSessionRepository lazy deserialization broken

[candrews]

The lazy loading work done for #1133 was undone by @vpavic's polish commit b61937d

The key problem is that this working code:

byte[] bytes = lobToBytes(rs, "ATTRIBUTE_BYTES");
session.delegate.setAttribute(attributeName, lazily(() -> deserialize(bytes)));

was changed to:

Object attributeValue = getBlobAsObject(rs, "ATTRIBUTE_BYTES");
session.delegate.setAttribute(attributeName, lazily(() -> attributeValue));

Note that the actual work of deserializing occurs in getBlobAsObject which is done outside of lazily. Also note that nothing is done in lazily - it just returns a value.

getBlobAsObject must be separated into two methods, one to convert the LOB to bytes and that must be done outside of the lazily, and one to deserialize the bytes to an object which must be done in the lazily.

Can b61937d please be reverted?

[vpavic]

Thanks for the report @candrews - indeed I mishandled that polish.

Can b61937d please be reverted?

Fixed yes, reverted no, because as stated in the #1133 the PR didn't have any tests.

[candrews]

Thank you very much! 👏