Skip to content

Consider possibility exclude PropertySourcesPlaceholderConfigurer in RedisHttpSessionConfiguration in version 1.3.x #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andreytkachuk31 opened this issue Nov 19, 2018 · 4 comments
Assignees
Labels
for: stack-overflow A question that's better suited to stackoverflow.com

Comments

@andreytkachuk31
Copy link

andreytkachuk31 commented Nov 19, 2018

Conditions:
We used spring-session module of version 1.1.x. And we had own PropertySourcesPlaceholderConfigurer bean with field ignoreUnresolvablePlaceholders=true configured with <context:property-placeholder ignore-unresolvable="true">

Issue:
We had to upgrade spring-session to 1.3.x version. We did it and we tried to run application but we got exception, because our unresolved properties were failed. It happened because there is RedisHttpSessionConfiguration in 1.3.x version and this configuration declares PropertySourcesPlaceholderConfigurer bean with field ignoreUnresolvablePlaceholders = false.

Could you consider possibility exclude or make optional bean PropertySourcesPlaceholderConfigurer in class RedisHttpSessionConfiguration in spring-session module of 1.3.x version?

@rwinch rwinch added the status: waiting-for-triage An issue we've not yet triaged label Nov 19, 2018
@rwinch
Copy link
Member

rwinch commented Nov 19, 2018

@andreytkachuk31 Thanks for the report.

@vpavic I am wondering if the best approach would be ignore unresolved properties. Thoughts?

@vpavic
Copy link
Contributor

vpavic commented Nov 19, 2018

We've removed the use of PropertySourcesPlaceholderConfigurer in Spring Sesion 2.0 via #907 and #910.

For 1.3, this is basically a duplicate of #867 - @andreytkachuk31, can you take a look at this comment and see if the proposed workaround helps?

@vpavic vpavic added for: stack-overflow A question that's better suited to stackoverflow.com status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 19, 2018
@andreytkachuk31
Copy link
Author

@rwinch @vpavic Proposed workaround helps. Thanks!

@vpavic vpavic removed the status: waiting-for-feedback We need additional information before we can continue label Nov 20, 2018
@vpavic
Copy link
Contributor

vpavic commented Nov 20, 2018

Thanks for following up @andreytkachuk31 - glad to hear you were able to work around it.

@vpavic vpavic closed this as completed Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: stack-overflow A question that's better suited to stackoverflow.com
Projects
None yet
Development

No branches or pull requests

3 participants