Skip to content

Simplify tests related to SameSite cookie directive support #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vpavic opened this issue Aug 3, 2018 · 0 comments
Closed

Simplify tests related to SameSite cookie directive support #1147

vpavic opened this issue Aug 3, 2018 · 0 comments
Assignees
@vpavic
Labels
in: build An issue in the build type: enhancement A general enhancement
Milestone
2.1.0.M2

Comments

@vpavic
Copy link
Contributor

vpavic commented Aug 3, 2018

The recently introduced support for SameSite cookie directive (see #1005 and 00465a6) required a lot of workarounds in our tests due to the fact we had to write cookie directly as Set-Cookie response header.

At the time, Spring Test framework didn't provide support for this use case, however things have been improved in SPR-17110. We should leverage this and simplify our tests.
@vpavic vpavic added type: enhancement A general enhancement in: build An issue in the build labels Aug 3, 2018
@vpavic vpavic added this to the 2.1.0.M2 milestone Aug 3, 2018
@vpavic vpavic self-assigned this Aug 3, 2018
@vpavic vpavic closed this as completed in 3f4873f Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vpavic vpavic

Labels
in: build An issue in the build type: enhancement A general enhancement
Projects
None yet
Milestone
2.1.0.M2
Development

No branches or pull requests
1 participant
@vpavic