Skip to content

Bug ClientCredentialsReactiveOAuth2AuthorizedClientProvider.hasTokenExpired #7558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andriy-z opened this issue Oct 23, 2019 · 1 comment
Closed

Bug ClientCredentialsReactiveOAuth2AuthorizedClientProvider.hasTokenExpired #7558

andriy-z opened this issue Oct 23, 2019 · 1 comment
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue

Comments

@andriy-z
Copy link

andriy-z commented Oct 23, 2019 •
edited
Loading

Summary

hasTokenExpired on ClientCredentialsReactiveOAuth2AuthorizedClientProvider don't work correct with clockSkew

Actual Behavior

private boolean hasTokenExpired(AbstractOAuth2Token token) {
return token.getExpiresAt().isBefore(Instant.now(this.clock).minus(this.clockSkew));
}

Expected Behavior

private boolean hasTokenExpired(AbstractOAuth2Token token) {
return token.getExpiresAt().isBefore(Instant.now(this.clock).plus(this.clockSkew));
}
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 23, 2019
@jgrandja
Copy link
Contributor

Duplicate of #7511

@jgrandja jgrandja marked this as a duplicate of #7511 Oct 23, 2019
@jgrandja jgrandja added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 23, 2019
@jgrandja jgrandja self-assigned this Oct 23, 2019
@jgrandja jgrandja added the in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) label Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jgrandja @spring-projects-issues @andriy-z