Skip to content

Revisit oauth2 module structure #4297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jgrandja opened this issue Apr 21, 2017 · 2 comments
Closed

Revisit oauth2 module structure #4297

jgrandja opened this issue Apr 21, 2017 · 2 comments
Assignees
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
Milestone

Comments

@jgrandja
Copy link
Contributor

jgrandja commented Apr 21, 2017

Summary

The new modules for the new OAuth 2.0 support include: oauth2-core and oauth2-client

The oauth2-core module includes OpenID Connect 1.0 specific implementation artifacts. Does it make sense to break up the module and include a new one called oauth2-oidc?

@jgrandja jgrandja added the in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) label Apr 21, 2017
@jgrandja jgrandja added this to the 5.0.0.M1 milestone Apr 21, 2017
@jgrandja jgrandja self-assigned this Apr 21, 2017
@jgrandja jgrandja modified the milestones: 5.0.0.M2, 5.0.0.M1 May 1, 2017
@rwinch rwinch modified the milestones: 5.0.0.M2, 5.0.0.M3 Jun 15, 2017
@jgrandja jgrandja modified the milestones: 5.0.0.M3, 5.0.0.M4 Jul 24, 2017
@jgrandja jgrandja mentioned this issue Aug 15, 2017
28 tasks
@rwinch rwinch modified the milestones: 5.0.0.M4, 5.0.0.M5 Sep 13, 2017
@jgrandja
Copy link
Contributor Author

jgrandja commented Sep 15, 2017

The current dependency hierarchy for the oauth2 modules is as follows:

spring-security-oauth2-core -> spring-security-core

spring-security-oauth2-client -> spring-security-oauth2-core, spring-security-jwt-jose

spring-security-jwt-jose -> spring-security-oauth2-core

I feel this module hierarchy is correct. I was contemplating splitting the OAuth 2.0 and OpenID Connect Core 1.0 into separate modules but after giving it some thought I don't feel this is necessary as it would introduce unnecessary complexity. OIDC core essentially extends from OAuth2 core and therefore are tightly bound.

The one consideration we should decide on is to potentially rename the following modules:

spring-security-oauth2-core -> spring-security-oauth2-oidc-core

spring-security-oauth2-client -> spring-security-oauth2-oidc-client

What are your thoughts on renaming @rwinch?

As we build out new features for OAuth2 / OIDC, I'm envisioning the following module/feature structure:

spring-security-oauth2-core

spring-security-oauth2-client

spring-security-jwt-jose

@jgrandja
Copy link
Contributor Author

@rwinch As discussed, we are good with the current module names so will close this and leave as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
Projects
None yet
Development

No branches or pull requests

2 participants