Skip to content

Commit d06eae9

Browse files
committed
Merge pull request #22 from zagyi/SEC-2107
SEC-2107: Fix Javadoc on methods of AbstractAuthenticationProcessingFilter
2 parents 7edb108 + 73ea8b5 commit d06eae9

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

web/src/main/java/org/springframework/security/web/authentication/AbstractAuthenticationProcessingFilter.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,8 @@ public void afterPropertiesSet() {
161161
* to perform the authentication. There are then three possible outcomes:
162162
* <ol>
163163
* <li>An <tt>Authentication</tt> object is returned.
164-
* The configured {link SessionAuthenticationStrategy} will be invoked followed by the
164+
* The configured {@link SessionAuthenticationStrategy} will be invoked (to handle any session-related behaviour
165+
* such as creating a new session to protect against session-fixation attacks) followed by the invocation of
165166
* {@link #successfulAuthentication(HttpServletRequest, HttpServletResponse, Authentication)
166167
* successfulAuthentication} method</li>
167168
* <li>An <tt>AuthenticationException</tt> occurs during authentication.
@@ -273,8 +274,6 @@ public abstract Authentication attemptAuthentication(HttpServletRequest request,
273274
* Default behaviour for successful authentication.
274275
* <ol>
275276
* <li>Sets the successful <tt>Authentication</tt> object on the {@link SecurityContextHolder}</li>
276-
* <li>Invokes the configured {@link SessionAuthenticationStrategy} to handle any session-related behaviour
277-
* (such as creating a new session to protect against session-fixation attacks).</li>
278277
* <li>Informs the configured <tt>RememberMeServices</tt> of the successful login</li>
279278
* <li>Fires an {@link InteractiveAuthenticationSuccessEvent} via the configured
280279
* <tt>ApplicationEventPublisher</tt></li>
@@ -298,8 +297,6 @@ protected void successfulAuthentication(HttpServletRequest request, HttpServletR
298297
* Default behaviour for successful authentication.
299298
* <ol>
300299
* <li>Sets the successful <tt>Authentication</tt> object on the {@link SecurityContextHolder}</li>
301-
* <li>Invokes the configured {@link SessionAuthenticationStrategy} to handle any session-related behaviour
302-
* (such as creating a new session to protect against session-fixation attacks).</li>
303300
* <li>Informs the configured <tt>RememberMeServices</tt> of the successful login</li>
304301
* <li>Fires an {@link InteractiveAuthenticationSuccessEvent} via the configured
305302
* <tt>ApplicationEventPublisher</tt></li>

0 commit comments

Comments
 (0)