Skip to content

Commit b91f108

Browse files
committed
Disable Flaky Tests
There was another flaky failure. While it seems clear what needs to be done to repair it, this commit disables these tests for now while the CI on a separate branch confirms after a few days that the tests are stable again. Issue gh-15395
1 parent 561c786 commit b91f108

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

saml2/saml2-service-provider/src/opensaml4Test/java/org/springframework/security/saml2/provider/service/registration/OpenSaml4AssertingPartyMetadataRepositoryTests.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import okhttp3.mockwebserver.RecordedRequest;
3838
import org.junit.jupiter.api.AfterAll;
3939
import org.junit.jupiter.api.BeforeAll;
40+
import org.junit.jupiter.api.Disabled;
4041
import org.junit.jupiter.api.Test;
4142
import org.opensaml.core.xml.XMLObject;
4243
import org.opensaml.core.xml.config.XMLObjectProviderRegistrySupport;
@@ -105,6 +106,7 @@ public static void shutdown() throws Exception {
105106
}
106107

107108
@Test
109+
@Disabled("See gh-15395")
108110
public void withMetadataUrlLocationWhenResolvableThenFindByEntityIdReturns() throws Exception {
109111
AssertingPartyMetadataRepository parties = OpenSaml4AssertingPartyMetadataRepository
110112
.withTrustedMetadataLocation(web.url("/entity.xml").toString())
@@ -119,6 +121,7 @@ public void withMetadataUrlLocationWhenResolvableThenFindByEntityIdReturns() thr
119121
}
120122

121123
@Test
124+
@Disabled("See gh-15395")
122125
public void withMetadataUrlLocationnWhenResolvableThenIteratorReturns() throws Exception {
123126
List<AssertingPartyMetadata> parties = new ArrayList<>();
124127
OpenSaml4AssertingPartyMetadataRepository.withTrustedMetadataLocation(web.url("/entities.xml").toString())
@@ -215,6 +218,7 @@ public void withMetadataClasspathLocationWhenNotFoundThenSaml2Exception() {
215218
}
216219

217220
@Test
221+
@Disabled("See gh-15395")
218222
public void withTrustedMetadataLocationWhenMatchingCredentialsThenVerifiesSignature() throws IOException {
219223
RelyingPartyRegistration registration = TestRelyingPartyRegistrations.full().build();
220224
EntityDescriptor descriptor = TestOpenSamlObjects.entityDescriptor(registration);
@@ -233,6 +237,7 @@ public void withTrustedMetadataLocationWhenMatchingCredentialsThenVerifiesSignat
233237
}
234238

235239
@Test
240+
@Disabled("See gh-15395")
236241
public void withTrustedMetadataLocationWhenMismatchingCredentialsThenSaml2Exception() throws IOException {
237242
RelyingPartyRegistration registration = TestRelyingPartyRegistrations.full().build();
238243
EntityDescriptor descriptor = TestOpenSamlObjects.entityDescriptor(registration);
@@ -328,6 +333,7 @@ public void withMetadataLocationWhenNoCredentialsThenException() {
328333
}
329334

330335
@Test
336+
@Disabled("See gh-15395")
331337
public void withMetadataLocationWhenMatchingCredentialsThenVerifiesSignature() throws IOException {
332338
RelyingPartyRegistration registration = TestRelyingPartyRegistrations.full().build();
333339
EntityDescriptor descriptor = TestOpenSamlObjects.entityDescriptor(registration);

saml2/saml2-service-provider/src/opensaml5Test/java/org/springframework/security/saml2/provider/service/registration/OpenSaml5AssertingPartyMetadataRepositoryTests.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import okhttp3.mockwebserver.RecordedRequest;
3838
import org.junit.jupiter.api.AfterAll;
3939
import org.junit.jupiter.api.BeforeAll;
40+
import org.junit.jupiter.api.Disabled;
4041
import org.junit.jupiter.api.Test;
4142
import org.opensaml.core.xml.XMLObject;
4243
import org.opensaml.core.xml.config.XMLObjectProviderRegistrySupport;
@@ -105,6 +106,7 @@ public static void shutdown() throws Exception {
105106
}
106107

107108
@Test
109+
@Disabled("See gh-15395")
108110
public void withMetadataUrlLocationWhenResolvableThenFindByEntityIdReturns() throws Exception {
109111
AssertingPartyMetadataRepository parties = OpenSaml5AssertingPartyMetadataRepository
110112
.withTrustedMetadataLocation(web.url("/entity.xml").toString())
@@ -119,6 +121,7 @@ public void withMetadataUrlLocationWhenResolvableThenFindByEntityIdReturns() thr
119121
}
120122

121123
@Test
124+
@Disabled("See gh-15395")
122125
public void withMetadataUrlLocationnWhenResolvableThenIteratorReturns() throws Exception {
123126
List<AssertingPartyMetadata> parties = new ArrayList<>();
124127
OpenSaml5AssertingPartyMetadataRepository.withTrustedMetadataLocation(web.url("/entities.xml").toString())
@@ -215,6 +218,7 @@ public void withMetadataClasspathLocationWhenNotFoundThenSaml2Exception() {
215218
}
216219

217220
@Test
221+
@Disabled("See gh-15395")
218222
public void withTrustedMetadataLocationWhenMatchingCredentialsThenVerifiesSignature() throws IOException {
219223
RelyingPartyRegistration registration = TestRelyingPartyRegistrations.full().build();
220224
EntityDescriptor descriptor = TestOpenSamlObjects.entityDescriptor(registration);
@@ -233,6 +237,7 @@ public void withTrustedMetadataLocationWhenMatchingCredentialsThenVerifiesSignat
233237
}
234238

235239
@Test
240+
@Disabled("See gh-15395")
236241
public void withTrustedMetadataLocationWhenMismatchingCredentialsThenSaml2Exception() throws IOException {
237242
RelyingPartyRegistration registration = TestRelyingPartyRegistrations.full().build();
238243
EntityDescriptor descriptor = TestOpenSamlObjects.entityDescriptor(registration);
@@ -328,6 +333,7 @@ public void withMetadataLocationWhenNoCredentialsThenException() {
328333
}
329334

330335
@Test
336+
@Disabled("See gh-15395")
331337
public void withMetadataLocationWhenMatchingCredentialsThenVerifiesSignature() throws IOException {
332338
RelyingPartyRegistration registration = TestRelyingPartyRegistrations.full().build();
333339
EntityDescriptor descriptor = TestOpenSamlObjects.entityDescriptor(registration);

0 commit comments

Comments
 (0)