Skip to content

Commit 6eca766

Browse files
milaneuhrwinch
authored andcommitted
Remove deprecated methods from CookieServerCsrfTokenRepository
1 parent 506a801 commit 6eca766

File tree

2 files changed

+7
-43
lines changed

2 files changed

+7
-43
lines changed

web/src/main/java/org/springframework/security/web/csrf/CookieCsrfTokenRepository.java

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -169,14 +169,6 @@ public void setCookieName(String cookieName) {
169169
this.cookieName = cookieName;
170170
}
171171

172-
/**
173-
* @deprecated Use {@link #setCookieCustomizer(Consumer)} instead.
174-
*/
175-
@Deprecated(since = "6.1")
176-
public void setCookieHttpOnly(boolean cookieHttpOnly) {
177-
this.cookieHttpOnly = cookieHttpOnly;
178-
}
179-
180172
private String getRequestContext(HttpServletRequest request) {
181173
String contextPath = request.getContextPath();
182174
return (contextPath.length() > 0) ? contextPath : "/";
@@ -230,32 +222,4 @@ public String getCookiePath() {
230222
return this.cookiePath;
231223
}
232224

233-
/**
234-
* @since 5.2
235-
* @deprecated Use {@link #setCookieCustomizer(Consumer)} instead.
236-
*/
237-
@Deprecated(since = "6.1")
238-
public void setCookieDomain(String cookieDomain) {
239-
this.cookieDomain = cookieDomain;
240-
}
241-
242-
/**
243-
* @since 5.4
244-
* @deprecated Use {@link #setCookieCustomizer(Consumer)} instead.
245-
*/
246-
@Deprecated(since = "6.1")
247-
public void setSecure(Boolean secure) {
248-
this.secure = secure;
249-
}
250-
251-
/**
252-
* @since 5.5
253-
* @deprecated Use {@link #setCookieCustomizer(Consumer)} instead.
254-
*/
255-
@Deprecated(since = "6.1")
256-
public void setCookieMaxAge(int cookieMaxAge) {
257-
Assert.isTrue(cookieMaxAge != 0, "cookieMaxAge cannot be zero");
258-
this.cookieMaxAge = cookieMaxAge;
259-
}
260-
261225
}

web/src/test/java/org/springframework/security/web/csrf/CookieCsrfTokenRepositoryTests.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ void saveTokenSecure() {
112112
@Test
113113
void saveTokenSecureFlagTrue() {
114114
this.request.setSecure(false);
115-
this.repository.setSecure(Boolean.TRUE);
115+
this.repository.setCookieCustomizer((cookie)-> cookie.secure(Boolean.TRUE));
116116
CsrfToken token = this.repository.generateToken(this.request);
117117
this.repository.saveToken(token, this.request, this.response);
118118
Cookie tokenCookie = this.response.getCookie(CookieCsrfTokenRepository.DEFAULT_CSRF_COOKIE_NAME);
@@ -132,7 +132,7 @@ void saveTokenSecureFlagTrueUsingCustomizer() {
132132
@Test
133133
void saveTokenSecureFlagFalse() {
134134
this.request.setSecure(true);
135-
this.repository.setSecure(Boolean.FALSE);
135+
this.repository.setCookieCustomizer((cookie)-> cookie.secure(Boolean.FALSE));
136136
CsrfToken token = this.repository.generateToken(this.request);
137137
this.repository.saveToken(token, this.request, this.response);
138138
Cookie tokenCookie = this.response.getCookie(CookieCsrfTokenRepository.DEFAULT_CSRF_COOKIE_NAME);
@@ -163,7 +163,7 @@ void saveTokenNull() {
163163

164164
@Test
165165
void saveTokenHttpOnlyTrue() {
166-
this.repository.setCookieHttpOnly(true);
166+
this.repository.setCookieCustomizer((cookie) -> cookie.httpOnly(true));
167167
CsrfToken token = this.repository.generateToken(this.request);
168168
this.repository.saveToken(token, this.request, this.response);
169169
Cookie tokenCookie = this.response.getCookie(CookieCsrfTokenRepository.DEFAULT_CSRF_COOKIE_NAME);
@@ -181,7 +181,7 @@ void saveTokenHttpOnlyTrueUsingCustomizer() {
181181

182182
@Test
183183
void saveTokenHttpOnlyFalse() {
184-
this.repository.setCookieHttpOnly(false);
184+
this.repository.setCookieCustomizer((cookie) -> cookie.httpOnly(false));
185185
CsrfToken token = this.repository.generateToken(this.request);
186186
this.repository.saveToken(token, this.request, this.response);
187187
Cookie tokenCookie = this.response.getCookie(CookieCsrfTokenRepository.DEFAULT_CSRF_COOKIE_NAME);
@@ -239,7 +239,7 @@ void saveTokenNullCustomPath() {
239239
@Test
240240
void saveTokenWithCookieDomain() {
241241
String domainName = "example.com";
242-
this.repository.setCookieDomain(domainName);
242+
this.repository.setCookieCustomizer((cookie) -> cookie.domain(domainName));
243243
CsrfToken token = this.repository.generateToken(this.request);
244244
this.repository.saveToken(token, this.request, this.response);
245245
Cookie tokenCookie = this.response.getCookie(CookieCsrfTokenRepository.DEFAULT_CSRF_COOKIE_NAME);
@@ -259,7 +259,7 @@ void saveTokenWithCookieDomainUsingCustomizer() {
259259
@Test
260260
void saveTokenWithCookieMaxAge() {
261261
int maxAge = 1200;
262-
this.repository.setCookieMaxAge(maxAge);
262+
this.repository.setCookieCustomizer((cookie) -> cookie.maxAge(maxAge));
263263
CsrfToken token = this.repository.generateToken(this.request);
264264
this.repository.saveToken(token, this.request, this.response);
265265
Cookie tokenCookie = this.response.getCookie(CookieCsrfTokenRepository.DEFAULT_CSRF_COOKIE_NAME);
@@ -506,7 +506,7 @@ void setHeaderNameNullIllegalArgumentException() {
506506

507507
@Test
508508
void setCookieMaxAgeZeroIllegalArgumentException() {
509-
assertThatIllegalArgumentException().isThrownBy(() -> this.repository.setCookieMaxAge(0));
509+
assertThatIllegalArgumentException().isThrownBy(() -> this.repository.setCookieCustomizer((cookie) -> cookie.maxAge(0)));
510510
}
511511

512512
}

0 commit comments

Comments
 (0)