Skip to content

Commit 3f83cb6

Browse files
committed
Remove deprecated methods from CookieServerCsrfTokenRepository
1 parent e920bfb commit 3f83cb6

File tree

2 files changed

+7
-43
lines changed

2 files changed

+7
-43
lines changed

web/src/main/java/org/springframework/security/web/csrf/CookieCsrfTokenRepository.java

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -158,14 +158,6 @@ public void setCookieName(String cookieName) {
158158
this.cookieName = cookieName;
159159
}
160160

161-
/**
162-
* @deprecated Use {@link #setCookieCustomizer(Consumer)} instead.
163-
*/
164-
@Deprecated(since = "6.1")
165-
public void setCookieHttpOnly(boolean cookieHttpOnly) {
166-
this.cookieHttpOnly = cookieHttpOnly;
167-
}
168-
169161
private String getRequestContext(HttpServletRequest request) {
170162
String contextPath = request.getContextPath();
171163
return (contextPath.length() > 0) ? contextPath : "/";
@@ -219,32 +211,4 @@ public String getCookiePath() {
219211
return this.cookiePath;
220212
}
221213

222-
/**
223-
* @since 5.2
224-
* @deprecated Use {@link #setCookieCustomizer(Consumer)} instead.
225-
*/
226-
@Deprecated(since = "6.1")
227-
public void setCookieDomain(String cookieDomain) {
228-
this.cookieDomain = cookieDomain;
229-
}
230-
231-
/**
232-
* @since 5.4
233-
* @deprecated Use {@link #setCookieCustomizer(Consumer)} instead.
234-
*/
235-
@Deprecated(since = "6.1")
236-
public void setSecure(Boolean secure) {
237-
this.secure = secure;
238-
}
239-
240-
/**
241-
* @since 5.5
242-
* @deprecated Use {@link #setCookieCustomizer(Consumer)} instead.
243-
*/
244-
@Deprecated(since = "6.1")
245-
public void setCookieMaxAge(int cookieMaxAge) {
246-
Assert.isTrue(cookieMaxAge != 0, "cookieMaxAge cannot be zero");
247-
this.cookieMaxAge = cookieMaxAge;
248-
}
249-
250214
}

web/src/test/java/org/springframework/security/web/csrf/CookieCsrfTokenRepositoryTests.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ void saveTokenSecure() {
108108
@Test
109109
void saveTokenSecureFlagTrue() {
110110
this.request.setSecure(false);
111-
this.repository.setSecure(Boolean.TRUE);
111+
this.repository.setCookieCustomizer((cookie)-> cookie.secure(Boolean.TRUE));
112112
CsrfToken token = this.repository.generateToken(this.request);
113113
this.repository.saveToken(token, this.request, this.response);
114114
Cookie tokenCookie = this.response.getCookie(CookieCsrfTokenRepository.DEFAULT_CSRF_COOKIE_NAME);
@@ -128,7 +128,7 @@ void saveTokenSecureFlagTrueUsingCustomizer() {
128128
@Test
129129
void saveTokenSecureFlagFalse() {
130130
this.request.setSecure(true);
131-
this.repository.setSecure(Boolean.FALSE);
131+
this.repository.setCookieCustomizer((cookie)-> cookie.secure(Boolean.FALSE));
132132
CsrfToken token = this.repository.generateToken(this.request);
133133
this.repository.saveToken(token, this.request, this.response);
134134
Cookie tokenCookie = this.response.getCookie(CookieCsrfTokenRepository.DEFAULT_CSRF_COOKIE_NAME);
@@ -159,7 +159,7 @@ void saveTokenNull() {
159159

160160
@Test
161161
void saveTokenHttpOnlyTrue() {
162-
this.repository.setCookieHttpOnly(true);
162+
this.repository.setCookieCustomizer((cookie) -> cookie.httpOnly(true));
163163
CsrfToken token = this.repository.generateToken(this.request);
164164
this.repository.saveToken(token, this.request, this.response);
165165
Cookie tokenCookie = this.response.getCookie(CookieCsrfTokenRepository.DEFAULT_CSRF_COOKIE_NAME);
@@ -177,7 +177,7 @@ void saveTokenHttpOnlyTrueUsingCustomizer() {
177177

178178
@Test
179179
void saveTokenHttpOnlyFalse() {
180-
this.repository.setCookieHttpOnly(false);
180+
this.repository.setCookieCustomizer((cookie) -> cookie.httpOnly(false));
181181
CsrfToken token = this.repository.generateToken(this.request);
182182
this.repository.saveToken(token, this.request, this.response);
183183
Cookie tokenCookie = this.response.getCookie(CookieCsrfTokenRepository.DEFAULT_CSRF_COOKIE_NAME);
@@ -235,7 +235,7 @@ void saveTokenNullCustomPath() {
235235
@Test
236236
void saveTokenWithCookieDomain() {
237237
String domainName = "example.com";
238-
this.repository.setCookieDomain(domainName);
238+
this.repository.setCookieCustomizer((cookie) -> cookie.domain(domainName));
239239
CsrfToken token = this.repository.generateToken(this.request);
240240
this.repository.saveToken(token, this.request, this.response);
241241
Cookie tokenCookie = this.response.getCookie(CookieCsrfTokenRepository.DEFAULT_CSRF_COOKIE_NAME);
@@ -255,7 +255,7 @@ void saveTokenWithCookieDomainUsingCustomizer() {
255255
@Test
256256
void saveTokenWithCookieMaxAge() {
257257
int maxAge = 1200;
258-
this.repository.setCookieMaxAge(maxAge);
258+
this.repository.setCookieCustomizer((cookie) -> cookie.maxAge(maxAge));
259259
CsrfToken token = this.repository.generateToken(this.request);
260260
this.repository.saveToken(token, this.request, this.response);
261261
Cookie tokenCookie = this.response.getCookie(CookieCsrfTokenRepository.DEFAULT_CSRF_COOKIE_NAME);
@@ -464,7 +464,7 @@ void setHeaderNameNullIllegalArgumentException() {
464464

465465
@Test
466466
void setCookieMaxAgeZeroIllegalArgumentException() {
467-
assertThatIllegalArgumentException().isThrownBy(() -> this.repository.setCookieMaxAge(0));
467+
assertThatIllegalArgumentException().isThrownBy(() -> this.repository.setCookieCustomizer((cookie) -> cookie.maxAge(0)));
468468
}
469469

470470
}

0 commit comments

Comments
 (0)