Skip to content

Conversation

@garyrussell
Copy link
Contributor

See spring-projects/spring-boot#14021 (comment)

Avoid using a bean of type Properties.

@artembilan
Copy link
Member

Well, with this I believe we need to change Spring Integration global properties from the Properties bean as well...

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one concern.
Although we can live with such a Javadoc if you insist.

Don't we need to deprecate a StreamsBuilderFactoryBean(StreamsConfig streamsConfig) ctor as well?


/**
* Wrapper for {@link StreamsBuilder} properties; used to avoid auto-configuring
* a generic {@link Properties} object in Boot.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a good idea to mentioned Spring Boot here.
More over in its non-official name.

I believe we can find some generic message to say here.

Thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the missed ctor.

@garyrussell
Copy link
Contributor Author

Well, with this I believe we need to change Spring Integration global properties from the Properties bean as well...

Yes, then I guess we can expose the props as boot auto config properties.

@artembilan artembilan merged commit 29df442 into spring-projects:master Aug 13, 2018
@garyrussell garyrussell deleted the autoConfig branch November 7, 2018 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants