From 623722cc9d99c8bd8cae5105ebb19fc4883e1bcb Mon Sep 17 00:00:00 2001 From: pbakker Date: Tue, 24 Sep 2024 13:54:53 -0700 Subject: [PATCH] SSE handler should dispose when the connection is closed, otherwise it will get into an error handling loop. --- .../graphql/server/webmvc/GraphQlSseHandler.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/spring-graphql/src/main/java/org/springframework/graphql/server/webmvc/GraphQlSseHandler.java b/spring-graphql/src/main/java/org/springframework/graphql/server/webmvc/GraphQlSseHandler.java index 1f846e26d..61454125e 100644 --- a/spring-graphql/src/main/java/org/springframework/graphql/server/webmvc/GraphQlSseHandler.java +++ b/spring-graphql/src/main/java/org/springframework/graphql/server/webmvc/GraphQlSseHandler.java @@ -106,6 +106,7 @@ private void writeResult(Map value) { this.sseBuilder.data(value); } catch (IOException exception) { + dispose(); onError(exception); } } @@ -130,6 +131,7 @@ protected void hookOnComplete() { catch (IOException exc) { throw new RuntimeException(exc); } + this.sseBuilder.complete(); }