Skip to content

Introduce GraphQL response media type in spring-graphql #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bclozel opened this issue Jan 13, 2025 · 0 comments
Closed

Introduce GraphQL response media type in spring-graphql #1110

bclozel opened this issue Jan 13, 2025 · 0 comments
Assignees
Labels
in: web Issues related to web handling type: enhancement A general enhancement
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Jan 13, 2025

Spring Framework recently reflected an official policy for MediaType enum values in spring-projects/spring-framework#33754.

The MediaType APPLICATION_GRAPHQL_RESPONSE does not qualify here and we already had to manage deprecations and transitions between MediaType APPLICATION_GRAPHQL/MediaType APPLICATION_GRAPHQL_RESPONSE for Spring Framework and Spring for GraphQL.

We should consider introducing and maintaining our own media types like GraphQlMediaType.RESPONSE in spring-graphql directly. Right now our transports are located in org.springframework.graphql.server and org.springframework.graphql.client, wich no obvious location for a shared component.

@bclozel bclozel added type: enhancement A general enhancement in: web Issues related to web handling labels Jan 13, 2025
@bclozel bclozel added this to the 1.4.x milestone Jan 13, 2025
@bclozel bclozel self-assigned this Jan 13, 2025
@bclozel bclozel added the for: team-attention An issue we need to discuss as a team to make progress label Jan 13, 2025
@bclozel bclozel modified the milestones: 1.4.x, 1.4.0-M1 Feb 4, 2025
@bclozel bclozel removed the for: team-attention An issue we need to discuss as a team to make progress label Feb 4, 2025
@bclozel bclozel closed this as completed in c015dbc Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues related to web handling type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant