Skip to content

getHandlerInternal repeated lookup for HandlerMethod #29591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShijunDeng opened this issue Nov 28, 2022 · 3 comments
Closed

getHandlerInternal repeated lookup for HandlerMethod #29591

ShijunDeng opened this issue Nov 28, 2022 · 3 comments
Labels
status: invalid An issue that we don't feel is valid

Comments

@ShijunDeng
Copy link

ShijunDeng commented Nov 28, 2022

when spring-boot-starter-actuator imported to my project :

image

there are 6 members in org.springframework.web.reactive.DispatcherHandler#handlerMappings. Part of those HandlerMappings are subclass of org.springframework.web.reactive.result.method.RequestMappingInfoHandlerMapping, which caused repeated call of org.springframework.web.reactive.result.method.AbstractHandlerMethodMapping#getHandlerInternal to lookup HandlerMethod.

  • AdditionalHealthEndpointPathsWebFluxHandlerMapping

image

  • WebFluxEndpointHandlerMapping

image

  • ControllerEndpointHandlerMapping

image

and so on.

this is my solution: #29589

@rstoyanchev
Copy link
Contributor

I don't understand what the problem is. Each HandlerMapping has its own registrations, and HandlerMappings are invoked in order until one of them returns a match. If the second is called, it means the ones before didn't find a match. Or, if the first one finds a match, then the second one is not called.

@rstoyanchev rstoyanchev added this to the Triage Queue milestone Dec 2, 2022
@rstoyanchev rstoyanchev added the status: waiting-for-feedback We need additional information before we can continue label Dec 2, 2022
@spring-projects-issues
Copy link
Collaborator

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues spring-projects-issues added the status: feedback-reminder We've sent a reminder that we need additional information before we can continue label Dec 9, 2022
@spring-projects-issues
Copy link
Collaborator

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

@spring-projects-issues spring-projects-issues removed status: waiting-for-feedback We need additional information before we can continue status: feedback-reminder We've sent a reminder that we need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 16, 2022
@sbrannen sbrannen removed this from the Triage Queue milestone Dec 16, 2022
@sbrannen sbrannen closed this as not planned Won't fix, can't repro, duplicate, stale Dec 16, 2022
@sbrannen sbrannen added the status: invalid An issue that we don't feel is valid label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

4 participants