Skip to content

Commit fb4a28f

Browse files
committed
Polish
See gh-22340
1 parent f7e53a0 commit fb4a28f

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

spring-core/src/main/java/org/springframework/util/MimeTypeUtils.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ public abstract class MimeTypeUtils {
167167
private static volatile Random random;
168168

169169
static {
170+
// Not using "parseMimeType" to avoid static init cost
170171
ALL = new MimeType("*", "*");
171172
APPLICATION_JSON = new MimeType("application", "json");
172173
APPLICATION_OCTET_STREAM = new MimeType("application", "octet-stream");

spring-web/src/main/java/org/springframework/http/MediaType.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,7 @@ public class MediaType extends MimeType implements Serializable {
323323

324324

325325
static {
326+
// Not using "valueOf' to avoid static init cost
326327
ALL = new MediaType("*", "*");
327328
APPLICATION_ATOM_XML = new MediaType("application", "atom+xml");
328329
APPLICATION_FORM_URLENCODED = new MediaType("application", "x-www-form-urlencoded");
@@ -552,6 +553,7 @@ public static List<MediaType> parseMediaTypes(@Nullable String mediaTypes) {
552553
if (!StringUtils.hasLength(mediaTypes)) {
553554
return Collections.emptyList();
554555
}
556+
// Avoid using java.util.stream.Stream in hot paths
555557
List<String> tokenizedTypes = MimeTypeUtils.tokenize(mediaTypes);
556558
List<MediaType> result = new ArrayList<>(tokenizedTypes.size());
557559
for (String type : tokenizedTypes) {

0 commit comments

Comments
 (0)