LocalSessionFactoryBean clears default MetadataSources on reinitialization

Issue: SPR-14815

Author: jhoeller

spring-orm/src/main/java/org/springframework/orm/hibernate5/LocalSessionFactoryBean.java

@@ -100,6 +100,8 @@ public class LocalSessionFactoryBean extends HibernateExceptionTranslator
 
 	private AsyncTaskExecutor bootstrapExecutor;
 
+	private boolean metadataSourcesAccessed = false;
+
 	private MetadataSources metadataSources;
 
 	private ResourcePatternResolver resourcePatternResolver;
@@ -340,6 +342,7 @@ public void setBootstrapExecutor(AsyncTaskExecutor bootstrapExecutor) {
 	 */
 	public void setMetadataSources(MetadataSources metadataSources) {
 		Assert.notNull(metadataSources, "MetadataSources must not be null");
+		this.metadataSourcesAccessed = true;
 		this.metadataSources = metadataSources;
 	}
 
@@ -352,6 +355,7 @@ public void setMetadataSources(MetadataSources metadataSources) {
 	 * @see LocalSessionFactoryBuilder#LocalSessionFactoryBuilder(DataSource, ResourceLoader, MetadataSources)
 	 */
 	public MetadataSources getMetadataSources() {
+		this.metadataSourcesAccessed = true;
 		if (this.metadataSources == null) {
 			BootstrapServiceRegistryBuilder builder = new BootstrapServiceRegistryBuilder();
 			if (this.resourcePatternResolver != null) {
@@ -386,6 +390,11 @@ public ResourceLoader getResourceLoader() {
 
 	@Override
 	public void afterPropertiesSet() throws IOException {
+		if (this.metadataSources != null && !this.metadataSourcesAccessed) {
+			// Repeated initialization with no user-customized MetadataSources -> clear it.
+			this.metadataSources = null;
+		}
+
 		LocalSessionFactoryBuilder sfb = new LocalSessionFactoryBuilder(
 				this.dataSource, getResourceLoader(), getMetadataSources());