Polishing.

Reorder methods, reformat code.

Original Pull Request: #2959

Author: mp911de

src/main/java/org/springframework/data/redis/listener/KeyExpirationEventMessageListener.java

@@ -29,8 +29,8 @@
  * @author Christoph Strobl
  * @since 1.7
  */
-public class KeyExpirationEventMessageListener extends KeyspaceEventMessageListener implements
-		ApplicationEventPublisherAware {
+public class KeyExpirationEventMessageListener extends KeyspaceEventMessageListener
+		implements ApplicationEventPublisherAware {
 
 	private static final Topic KEYEVENT_EXPIRED_TOPIC = new PatternTopic("__keyevent@*__:expired");
 
@@ -45,6 +45,11 @@ public KeyExpirationEventMessageListener(RedisMessageListenerContainer listenerC
 		super(listenerContainer);
 	}
 
+	@Override
+	public void setApplicationEventPublisher(ApplicationEventPublisher applicationEventPublisher) {
+		this.publisher = applicationEventPublisher;
+	}
+
 	@Override
 	protected void doRegister(RedisMessageListenerContainer listenerContainer) {
 		listenerContainer.addMessageListener(this, KEYEVENT_EXPIRED_TOPIC);
@@ -67,8 +72,4 @@ protected void publishEvent(RedisKeyExpiredEvent event) {
 		}
 	}
 
-	@Override
-	public void setApplicationEventPublisher(ApplicationEventPublisher applicationEventPublisher) {
-		this.publisher = applicationEventPublisher;
-	}
 }

src/main/java/org/springframework/data/redis/listener/KeyspaceEventMessageListener.java

@@ -22,6 +22,8 @@
 import org.springframework.data.redis.connection.Message;
 import org.springframework.data.redis.connection.MessageListener;
 import org.springframework.data.redis.connection.RedisConnection;
+import org.springframework.data.redis.connection.RedisConnectionFactory;
+import org.springframework.data.redis.connection.RedisServerCommands;
 import org.springframework.lang.Nullable;
 import org.springframework.util.Assert;
 import org.springframework.util.ObjectUtils;
@@ -40,7 +42,7 @@ public abstract class KeyspaceEventMessageListener implements MessageListener, I
 
 	private final RedisMessageListenerContainer listenerContainer;
 
-	private String keyspaceNotificationsConfigParameter = "EA";
+	private @Nullable String keyspaceNotificationsConfigParameter = "EA";
 
 	/**
 	 * Creates new {@link KeyspaceEventMessageListener}.
@@ -53,6 +55,26 @@ public KeyspaceEventMessageListener(RedisMessageListenerContainer listenerContai
 		this.listenerContainer = listenerContainer;
 	}
 
+	/**
+	 * Set the configuration string to use for {@literal notify-keyspace-events}.
+	 *
+	 * @param keyspaceNotificationsConfigParameter can be {@literal null}.
+	 * @since 1.8
+	 */
+	public void setKeyspaceNotificationsConfigParameter(@Nullable String keyspaceNotificationsConfigParameter) {
+		this.keyspaceNotificationsConfigParameter = keyspaceNotificationsConfigParameter;
+	}
+
+	@Override
+	public void afterPropertiesSet() {
+		init();
+	}
+
+	@Override
+	public void destroy() throws Exception {
+		listenerContainer.removeMessageListener(this);
+	}
+
 	@Override
 	public void onMessage(Message message, @Nullable byte[] pattern) {
 
@@ -76,20 +98,18 @@ public void onMessage(Message message, @Nullable byte[] pattern) {
 	 */
 	public void init() {
 
-		if (StringUtils.hasText(keyspaceNotificationsConfigParameter)) {
+		RedisConnectionFactory connectionFactory = listenerContainer.getConnectionFactory();
 
-			RedisConnection connection = listenerContainer.getConnectionFactory().getConnection();
+		if (StringUtils.hasText(keyspaceNotificationsConfigParameter) && connectionFactory != null) {
 
-			try {
+			try (RedisConnection connection = connectionFactory.getConnection()) {
 
-				Properties config = connection.getConfig("notify-keyspace-events");
+				RedisServerCommands commands = connection.serverCommands();
+				Properties config = commands.getConfig("notify-keyspace-events");
 
 				if (!StringUtils.hasText(config.getProperty("notify-keyspace-events"))) {
-					connection.setConfig("notify-keyspace-events", keyspaceNotificationsConfigParameter);
+					commands.setConfig("notify-keyspace-events", keyspaceNotificationsConfigParameter);
 				}
-
-			} finally {
-				connection.close();
 			}
 		}
 
@@ -105,23 +125,4 @@ protected void doRegister(RedisMessageListenerContainer container) {
 		listenerContainer.addMessageListener(this, TOPIC_ALL_KEYEVENTS);
 	}
 
-	@Override
-	public void destroy() throws Exception {
-		listenerContainer.removeMessageListener(this);
-	}
-
-	/**
-	 * Set the configuration string to use for {@literal notify-keyspace-events}.
-	 *
-	 * @param keyspaceNotificationsConfigParameter can be {@literal null}.
-	 * @since 1.8
-	 */
-	public void setKeyspaceNotificationsConfigParameter(String keyspaceNotificationsConfigParameter) {
-		this.keyspaceNotificationsConfigParameter = keyspaceNotificationsConfigParameter;
-	}
-
-	@Override
-	public void afterPropertiesSet() throws Exception {
-		init();
-	}
 }