GH-2248 - Don't swallow or delete cause of translated exceptions.

This fixes #2248.

Author: michael-simons

src/main/java/org/springframework/data/neo4j/core/Neo4jPersistenceExceptionTranslator.java

@@ -102,7 +102,7 @@ private static DataAccessException translateImpl(Neo4jException e,
 		String msg = String.format("%s; Error code '%s'", e.getMessage(), optionalErrorCode.orElse("n/a"));
 
 		return optionalErrorCode.flatMap(code -> ERROR_CODE_MAPPINGS.getOrDefault(code, Optional.empty()))
-				.orElse(defaultTranslationProvider).apply(msg, e.getCause());
+				.orElse(defaultTranslationProvider).apply(msg, e);
 	}
 
 	static {

src/test/java/org/springframework/data/neo4j/core/Neo4jPersistenceExceptionTranslatorTest.java

@@ -36,7 +36,7 @@ void shouldHandleNullErrorCode() {
 		DataAccessException dataAccessException = translator.translateExceptionIfPossible(new LossyCoercion("Long", "Int"));
 		assertThat(dataAccessException).isNotNull().isInstanceOf(InvalidDataAccessApiUsageException.class);
 		assertThat(dataAccessException.getMessage())
-				.isEqualTo("Cannot coerce Long to Int without losing precision; Error code 'N/A'");
+				.startsWith("Cannot coerce Long to Int without losing precision; Error code 'N/A'");
 	}
 
 	@Test
@@ -47,6 +47,6 @@ void shouldKeepErrorCodeIntact() {
 				new ClientException("Neo.ClientError.Statement.EntityNotFound", "Something went wrong."));
 		assertThat(dataAccessException).isNotNull().isInstanceOf(InvalidDataAccessResourceUsageException.class);
 		assertThat(dataAccessException.getMessage())
-				.isEqualTo("Something went wrong.; Error code 'Neo.ClientError.Statement.EntityNotFound'");
+				.startsWith("Something went wrong.; Error code 'Neo.ClientError.Statement.EntityNotFound'");
 	}
 }

src/test/java/org/springframework/data/neo4j/core/support/RetryExceptionPredicateTest.java

@@ -24,6 +24,7 @@
 import org.neo4j.driver.exceptions.ServiceUnavailableException;
 import org.neo4j.driver.exceptions.SessionExpiredException;
 import org.springframework.dao.TransientDataAccessResourceException;
+import org.springframework.data.neo4j.core.Neo4jPersistenceExceptionTranslator;
 
 /**
  * @author Michael J. Simons
@@ -47,6 +48,15 @@ void shouldNotRetryOnRandomIllegalStateExceptions() {
 		assertThat(predicate.test(new IllegalStateException())).isFalse();
 	}
 
+	@Test
+	void shouldPlayWellWithExceptionTranslator() {
+
+		Neo4jPersistenceExceptionTranslator translator = new Neo4jPersistenceExceptionTranslator();
+		Exception e = translator.translateExceptionIfPossible(new SessionExpiredException("Schade"));
+		RetryExceptionPredicate predicate = new RetryExceptionPredicate();
+		assertThat(predicate.test(e)).isTrue();
+	}
+
 	@ParameterizedTest
 	@ValueSource(classes = { SessionExpiredException.class, ServiceUnavailableException.class })
 	void shouldRetryOnObviousRetryableExceptions(Class<? extends Exception> typeOfException) {

src/test/java/org/springframework/data/neo4j/integration/imperative/ExceptionTranslationIT.java

@@ -83,7 +83,7 @@ void exceptionsFromClientShouldBeTranslated(@Autowired Neo4jClient neo4jClient)
 
 		assertThatExceptionOfType(DataIntegrityViolationException.class)
 				.isThrownBy(() -> neo4jClient.query("CREATE (:SimplePerson {name: 'Tom'})").run()).withMessageMatching(
-						"Node\\(\\d+\\) already exists with label `SimplePerson` and property `name` = '[\\w\\s]+'; Error code 'Neo.ClientError.Schema.ConstraintValidationFailed'");
+						"Node\\(\\d+\\) already exists with label `SimplePerson` and property `name` = '[\\w\\s]+'; Error code 'Neo.ClientError.Schema.ConstraintValidationFailed';.*");
 	}
 
 	@Test
@@ -92,7 +92,7 @@ void exceptionsFromRepositoriesShouldBeTranslated(@Autowired SimplePersonReposit
 
 		assertThatExceptionOfType(DataIntegrityViolationException.class)
 				.isThrownBy(() -> repository.save(new SimplePerson("Jerry"))).withMessageMatching(
-						"Node\\(\\d+\\) already exists with label `SimplePerson` and property `name` = '[\\w\\s]+'; Error code 'Neo.ClientError.Schema.ConstraintValidationFailed'");
+						"Node\\(\\d+\\) already exists with label `SimplePerson` and property `name` = '[\\w\\s]+'; Error code 'Neo.ClientError.Schema.ConstraintValidationFailed';.*");
 	}
 
 	/*
@@ -105,7 +105,7 @@ void exceptionsOnRepositoryBeansShouldBeTranslated(@Autowired CustomDAO customDA
 
 		assertThatExceptionOfType(DataIntegrityViolationException.class).isThrownBy(() -> customDAO.createPerson())
 				.withMessageMatching(
-						"Node\\(\\d+\\) already exists with label `SimplePerson` and property `name` = '[\\w\\s]+'; Error code 'Neo.ClientError.Schema.ConstraintValidationFailed'");
+						"Node\\(\\d+\\) already exists with label `SimplePerson` and property `name` = '[\\w\\s]+'; Error code 'Neo.ClientError.Schema.ConstraintValidationFailed';.*");
 	}
 
 	interface SimplePersonRepository extends Neo4jRepository<SimplePerson, Long> {}

src/test/java/org/springframework/data/neo4j/integration/reactive/ReactiveExceptionTranslationIT.java

@@ -58,7 +58,7 @@ class ReactiveExceptionTranslationIT {
 	// @formatter:off
 	private final Predicate<Throwable> aTranslatedException = ex -> ex instanceof DataIntegrityViolationException && //
 			ex.getMessage().matches(
-					"Node\\(\\d+\\) already exists with label `SimplePerson` and property `name` = '[\\w\\s]+'; Error code 'Neo.ClientError.Schema.ConstraintValidationFailed'");
+					"Node\\(\\d+\\) already exists with label `SimplePerson` and property `name` = '[\\w\\s]+'; Error code 'Neo.ClientError.Schema.ConstraintValidationFailed';.*");
 	// @formatter:on
 
 	@BeforeAll