From 9f42c35e37332d6177a74ed168e420aecdcbb225 Mon Sep 17 00:00:00 2001 From: yyfMichaelYan Date: Mon, 8 Nov 2021 12:09:45 -0600 Subject: [PATCH] fix flaky test writesAndReadsCustomFieldsConvertedClass --- .../data/couchbase/core/mapping/CouchbaseDocument.java | 10 +++++----- .../core/mapping/MappingCouchbaseConverterTests.java | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main/java/org/springframework/data/couchbase/core/mapping/CouchbaseDocument.java b/src/main/java/org/springframework/data/couchbase/core/mapping/CouchbaseDocument.java index 26a6834dd..0e2164536 100644 --- a/src/main/java/org/springframework/data/couchbase/core/mapping/CouchbaseDocument.java +++ b/src/main/java/org/springframework/data/couchbase/core/mapping/CouchbaseDocument.java @@ -18,14 +18,14 @@ import com.couchbase.client.java.json.JsonObject; -import java.util.HashMap; +import java.util.TreeMap; import java.util.Map; /** * A {@link CouchbaseDocument} is an abstract representation of a document stored inside Couchbase Server. *

*

- * It acts like a {@link HashMap}, but only allows those types to be written that are supported by the underlying + * It acts like a {@link TreeMap}, but only allows those types to be written that are supported by the underlying * storage format, which is currently JSON. Note that JSON conversion is not happening here, but performed at a * different stage based on the payload stored in the {@link CouchbaseDocument}. *

@@ -85,7 +85,7 @@ public CouchbaseDocument(final String id) { public CouchbaseDocument(final String id, final int expiration) { this.id = id; this.expiration = expiration; - content = new HashMap<>(); + content = new TreeMap<>(); } /** @@ -119,8 +119,8 @@ public final Object get(final String key) { * * @return */ - public final HashMap export() { - HashMap toExport = new HashMap(content); + public final TreeMap export() { + TreeMap toExport = new TreeMap(content); for (Map.Entry entry : content.entrySet()) { if (entry.getValue() instanceof CouchbaseDocument) { toExport.put(entry.getKey(), ((CouchbaseDocument) entry.getValue()).export()); diff --git a/src/test/java/org/springframework/data/couchbase/core/mapping/MappingCouchbaseConverterTests.java b/src/test/java/org/springframework/data/couchbase/core/mapping/MappingCouchbaseConverterTests.java index 49652573a..d807c915b 100644 --- a/src/test/java/org/springframework/data/couchbase/core/mapping/MappingCouchbaseConverterTests.java +++ b/src/test/java/org/springframework/data/couchbase/core/mapping/MappingCouchbaseConverterTests.java @@ -455,7 +455,7 @@ void writesAndReadsCustomConvertedClass() { List listOfValues = new ArrayList<>(); listOfValues.add(value); listOfValues.add(value2); - Map mapOfValues = new HashMap<>(); + Map mapOfValues = new TreeMap<>(); mapOfValues.put("val1", value); mapOfValues.put("val2", value2);