Skip to content

QueryMethod.isCollectionQuery() returns false for Flux<T> findByXXX(..., pageRequest) [DATACOUCH-673] #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Dec 10, 2020 · 1 comment · Fixed by #278
Assignees
Labels
type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link

Michael Reiche opened DATACOUCH-673 and commented

This is mostly a note to myself -

QueryMethod.isCollectionQuery() returns false for Flux<T> findByXXX(..., pageRequest)

airportRepository.findAllByIataLikeOrderByIata("S%", pageRequest)

To resolve this, not only does CouchbaseQueryMethod (or ReactiveCouchbaseQueryMethod) need to override isCollectionQuery() :

@Override
public boolean isCollectionQuery() {
return (Boolean) this.isCollectionQueryCouchbase.get();
}

But the lazy field from QueryMethod 'isCollectionQuery' should be substituted from a lazy field from [Reactive]CouchbaseQueryMethod


No further details from DATACOUCH-673

@spring-projects-issues spring-projects-issues added the type: enhancement A general enhancement label Dec 31, 2020
@mikereiche mikereiche linked a pull request Jan 14, 2021 that will close this issue
5 tasks
@mikereiche
Copy link
Collaborator

I believe this was fixed in one of the 588 part 1 merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants