Skip to content

Commit dbfbd33

Browse files
committed
Revert changes to public apis that were altered instead of just deprecated.
Closes #1092.
1 parent 03c96d9 commit dbfbd33

File tree

5 files changed

+30
-11
lines changed

5 files changed

+30
-11
lines changed

src/main/java/org/springframework/data/couchbase/repository/query/CouchbaseRepositoryQuery.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,11 @@ public class CouchbaseRepositoryQuery implements RepositoryQuery {
3535
private final QueryMethodEvaluationContextProvider evaluationContextProvider;
3636

3737
public CouchbaseRepositoryQuery(final CouchbaseOperations operations, final CouchbaseQueryMethod queryMethod,
38-
final NamedQueries namedQueries, final QueryMethodEvaluationContextProvider evaluationContextProvider) {
38+
final NamedQueries namedQueries) {
3939
this.operations = operations;
4040
this.queryMethod = queryMethod;
4141
this.namedQueries = namedQueries;
42-
this.evaluationContextProvider = evaluationContextProvider;
43-
throw new RuntimeException("Deprecated");
42+
this.evaluationContextProvider = QueryMethodEvaluationContextProvider.DEFAULT;
4443
}
4544

4645
@Override

src/main/java/org/springframework/data/couchbase/repository/query/N1qlRepositoryQueryExecutor.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ public N1qlRepositoryQueryExecutor(final CouchbaseOperations operations, final C
4747
this.queryMethod = queryMethod;
4848
this.namedQueries = namedQueries;
4949
this.evaluationContextProvider = evaluationContextProvider;
50-
throw new RuntimeException("Deprecated");
5150
}
5251

5352
private static final SpelExpressionParser SPEL_PARSER = new SpelExpressionParser();
@@ -70,7 +69,8 @@ public Object execute(final Object[] parameters) {
7069
SPEL_PARSER, evaluationContextProvider, namedQueries).createQuery();
7170
} else {
7271
final PartTree tree = new PartTree(queryMethod.getName(), domainClass);
73-
query = new N1qlQueryCreator(tree, accessor, queryMethod, operations.getConverter(), operations.getBucketName()).createQuery();
72+
query = new N1qlQueryCreator(tree, accessor, queryMethod, operations.getConverter(), operations.getBucketName())
73+
.createQuery();
7474
}
7575

7676
ExecutableFindByQueryOperation.ExecutableFindByQuery<?> operation = (ExecutableFindByQueryOperation.ExecutableFindByQuery<?>) operations

src/main/java/org/springframework/data/couchbase/repository/query/ReactiveCouchbaseRepositoryQuery.java

+3-5
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,12 @@ public class ReactiveCouchbaseRepositoryQuery extends AbstractReactiveCouchbaseQ
3636
private final QueryMethodEvaluationContextProvider evaluationContextProvider;
3737

3838
public ReactiveCouchbaseRepositoryQuery(final ReactiveCouchbaseOperations operations,
39-
final ReactiveCouchbaseQueryMethod queryMethod, final NamedQueries namedQueries,
40-
final QueryMethodEvaluationContextProvider evaluationContextProvider) {
41-
super(queryMethod, operations, new SpelExpressionParser(), evaluationContextProvider);
39+
final ReactiveCouchbaseQueryMethod queryMethod, final NamedQueries namedQueries) {
40+
super(queryMethod, operations, new SpelExpressionParser(), QueryMethodEvaluationContextProvider.DEFAULT);
4241
this.operations = operations;
4342
this.queryMethod = queryMethod;
4443
this.namedQueries = namedQueries;
45-
this.evaluationContextProvider = evaluationContextProvider;
46-
throw new RuntimeException("Deprecated");
44+
this.evaluationContextProvider = QueryMethodEvaluationContextProvider.DEFAULT;
4745
}
4846

4947
@Override

src/main/java/org/springframework/data/couchbase/repository/query/ReactiveN1qlRepositoryQueryExecutor.java

-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ public ReactiveN1qlRepositoryQueryExecutor(final ReactiveCouchbaseOperations ope
4040
this.queryMethod = queryMethod;
4141
this.namedQueries = namedQueries;
4242
this.evaluationContextProvider = evaluationContextProvider;
43-
throw new RuntimeException("Deprecated");
4443
}
4544

4645
/**

src/test/java/org/springframework/data/couchbase/repository/CouchbaseRepositoryQueryIntegrationTests.java

+23
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import static org.junit.jupiter.api.Assertions.assertThrows;
2424
import static org.junit.jupiter.api.Assertions.assertTrue;
2525

26+
import java.lang.reflect.Method;
2627
import java.util.ArrayList;
2728
import java.util.Arrays;
2829
import java.util.List;
@@ -40,6 +41,7 @@
4041
import org.springframework.dao.DataIntegrityViolationException;
4142
import org.springframework.data.couchbase.CouchbaseClientFactory;
4243
import org.springframework.data.couchbase.config.AbstractCouchbaseConfiguration;
44+
import org.springframework.data.couchbase.core.CouchbaseTemplate;
4345
import org.springframework.data.couchbase.domain.Address;
4446
import org.springframework.data.couchbase.domain.Airport;
4547
import org.springframework.data.couchbase.domain.AirportRepository;
@@ -48,13 +50,17 @@
4850
import org.springframework.data.couchbase.domain.User;
4951
import org.springframework.data.couchbase.domain.UserRepository;
5052
import org.springframework.data.couchbase.repository.config.EnableCouchbaseRepositories;
53+
import org.springframework.data.couchbase.repository.query.CouchbaseQueryMethod;
54+
import org.springframework.data.couchbase.repository.query.CouchbaseRepositoryQuery;
5155
import org.springframework.data.couchbase.util.Capabilities;
5256
import org.springframework.data.couchbase.util.ClusterAwareIntegrationTests;
5357
import org.springframework.data.couchbase.util.ClusterType;
5458
import org.springframework.data.couchbase.util.IgnoreWhen;
5559
import org.springframework.data.domain.Page;
5660
import org.springframework.data.domain.PageRequest;
5761
import org.springframework.data.domain.Pageable;
62+
import org.springframework.data.projection.SpelAwareProxyProjectionFactory;
63+
import org.springframework.data.repository.core.support.DefaultRepositoryMetadata;
5864
import org.springframework.test.context.junit.jupiter.SpringJUnitConfig;
5965

6066
import com.couchbase.client.core.error.IndexExistsException;
@@ -76,6 +82,8 @@ public class CouchbaseRepositoryQueryIntegrationTests extends ClusterAwareIntegr
7682

7783
@Autowired UserRepository userRepository;
7884

85+
@Autowired CouchbaseTemplate couchbaseTemplate;
86+
7987
@BeforeEach
8088
public void beforeEach() {
8189
try {
@@ -305,6 +313,21 @@ void deleteAllById() {
305313
}
306314
}
307315

316+
@Test
317+
void couchbaseRepositoryQuery() throws Exception {
318+
User user = new User("1", "Dave", "Wilson");
319+
userRepository.save(user);
320+
String input = "findByFirstname";
321+
Method method = UserRepository.class.getMethod(input, String.class);
322+
CouchbaseQueryMethod queryMethod = new CouchbaseQueryMethod(method,
323+
new DefaultRepositoryMetadata(UserRepository.class), new SpelAwareProxyProjectionFactory(),
324+
couchbaseTemplate.getConverter().getMappingContext());
325+
326+
CouchbaseRepositoryQuery query = new CouchbaseRepositoryQuery(couchbaseTemplate, queryMethod, null);
327+
List<User> users = (List<User>)query.execute(new String[] { "Dave" });
328+
assertEquals(user, users.get(0));
329+
}
330+
308331
private void sleep(int millis) {
309332
try {
310333
Thread.sleep(millis); // so they are executed out-of-order

0 commit comments

Comments
 (0)