Skip to content

Editing pass for the Actuator section #27759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Buzzardo
Copy link

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 18, 2021
@philwebb philwebb added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 18, 2021
@philwebb philwebb added this to the 2.6.x milestone Aug 18, 2021
@philwebb philwebb added the status: on-hold We can't start working on this issue yet label Aug 18, 2021
@wilkinsona
Copy link
Member

Sorry, I typo'd the issue number in the message for 6be27e2.

@wilkinsona wilkinsona reopened this Aug 19, 2021
@philwebb philwebb marked this pull request as draft August 24, 2021 15:58
Including removing the ==== fences around code blocks.
@philwebb philwebb self-assigned this Sep 8, 2021
@philwebb philwebb removed the status: on-hold We can't start working on this issue yet label Sep 9, 2021
philwebb pushed a commit that referenced this pull request Sep 9, 2021
Improve consistency of the asciidoctor markup and formatting for
the actuator section.

See gh-27759
philwebb pushed a commit that referenced this pull request Sep 9, 2021
Update example lead-in text to a slightly shorter form.

For example
	"as shown in the following example"
Becomes
	"as the following example shows"

See gh-27759
philwebb pushed a commit that referenced this pull request Sep 9, 2021
Edit the actuator docs so that more "You can..." phrasing is used.

For example
	"Auditing can be enabled by providing"
becomes
	"You can enable auditing by providing"

See gh-27759
philwebb pushed a commit that referenced this pull request Sep 9, 2021
@philwebb philwebb closed this in 3884ec3 Sep 9, 2021
@philwebb
Copy link
Member

philwebb commented Sep 9, 2021

Thanks @Buzzardo. I've rebased this PR and split it up into a number of smaller commits before pushing. I'm keen to try and improve the consistency across the board for the documentation so I've opened #27895 and tried to identify a bunch of changes that we can make (based on things observed in this PR). Please feel free to add any more that you think of.

I think if we can make those broad cross-cutting changes first (and one at a time) it should make the actual editing commits smaller and much easier to review.

@philwebb philwebb added type: task A general task and removed type: documentation A documentation update labels Sep 9, 2021
@philwebb philwebb removed this from the 2.6.x milestone Sep 9, 2021
@philwebb philwebb added this to the 2.6.0-M3 milestone Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants