Remove unused method parameters #25986
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
|
Test failure seems unrelated. |
|
Nice! |
philwebb
added
type: task
I've just seen the same failure. I believe it's due to this change in Spring Security. I've reached out to the Security team for some guidance as I'm not sure if the change is intentional and if we need to add |
|
The |
| private void onApplicationPreparedEvent() { | ||
| finish(); | ||
| } | ||
|
|
||
| private void onApplicationFailedEvent(ApplicationFailedEvent event) { | ||
| private void onApplicationFailedEvent() { | ||
| finish(); | ||
| } |
There was a problem hiding this comment.
It seems a bit ambiguous to call it a handler function for the event by deleting the event parameter.
Wouldn't it be better to get rid of the wrapper function and call finish() directly in onApplicationEvent()?
There was a problem hiding this comment.
Thought about that actually, but I liked the clear separation of things here. For me they are still the containers for the logic that should happen in case of the respective event and just share the common finish() call - regardless of the fact that they don't need the parameter. But I have no strong feelings for either option. Let's see what the team thinks and I'll gladly change to whatever is preferred.
There was a problem hiding this comment.
I prefer it as currently proposed.
Hi,
this PR removes a couple unused method parameters.
Cheers,
Christoph