Skip to content

Document using @Profile with @ConfigurationProperties #16622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kedar-joshi wants to merge 1 commit into from
Closed

Document using @Profile with @ConfigurationProperties #16622

kedar-joshi wants to merge 1 commit into from

Conversation

@kedar-joshi
Copy link
Contributor

@kedar-joshi kedar-joshi commented Apr 23, 2019 •
edited
Loading

Documented use of @Profile with @ConfigurationProperties.

See gh-16612

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 23, 2019
@snicoll
Copy link
Member

snicoll commented Apr 23, 2019

Thanks for the PR but I am not 100% sure that I want to document that with such a broad scope as this one. While @Component and @Configuration are clearly stereotypes linked to component scan, @ConfigurationProperties isn't.

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Apr 23, 2019
@wilkinsona
Copy link
Member

wilkinsona commented Apr 23, 2019

I think this is worth documenting as proposed and/or by mentioning @Profile in the documentation for @ConfigurationPropertiesScan.

@wilkinsona wilkinsona added type: documentation A documentation update and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Apr 24, 2019
@wilkinsona wilkinsona added this to the 2.2.x milestone Apr 24, 2019
@philwebb philwebb mentioned this pull request Apr 24, 2019
Closed
@wilkinsona wilkinsona changed the title Documentation update for gh-16612 Document using @Profile with @ConfigurationProperties Apr 24, 2019
@mbhave
Copy link
Contributor

mbhave commented Apr 30, 2019

I've added merge-with-amendments so that we can add documentation regarding this as part of merging the PR.

@mbhave mbhave added the for: merge-with-amendments Needs some changes when we merge label Apr 30, 2019
@mbhave mbhave modified the milestones: 2.2.x, 2.2.0.M3 Apr 30, 2019
@mbhave mbhave closed this in d4435e0 Apr 30, 2019
mbhave added a commit that referenced this pull request Apr 30, 2019
@mbhave
Merge pull request #16622 from Kedar Joshi
8b30ad2 
* pr/16622:
  Polish "Document use of @Profile with @ConfigurationProperties scanning"
  Document use of @Profile with @ConfigurationProperties scanning
@mbhave
Copy link
Contributor

mbhave commented Apr 30, 2019

Thanks @kedar-joshi. This is now merged into master.

@kedar-joshi kedar-joshi deleted the gh-16612-documentation branch May 1, 2019 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

for: merge-with-amendments Needs some changes when we merge type: documentation A documentation update

Projects

None yet

Milestone

2.2.0.M3

Development

Successfully merging this pull request may close these issues.

5 participants

@kedar-joshi @snicoll @wilkinsona @mbhave @spring-projects-issues