Improve Spring Session DefaultCookieSerializer auto-configuration #16513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spring Session's own configuration support (i.e. SpringHttpSessionConfiguration) will configure the default DefaultCookieSerializer with rememberMeRequestAttribute if SpringSessionRememberMeServices bean has been detected in the application context. In contrast, Spring Boot's auto-configured DefaultCookieSerializer does not do this which results in a different out-of-the-box experience for users that rely on Spring Session's remember-me integration. This commit improves Spring Session DefaultCookieSerializer auto-configuration to match Spring Session's behavior and make the auto-configured DefaultCookieSerializer aware of SpringSessionRememberMeServices bean.
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: enhancement
Contributor
|
Should we do this in 2.1.x? |
Contributor
Author
|
I see no issues with that. It's a small change that affects only user the rely on Spring Session's remember-me integration, and for those it feels like a bug. But after all, auto-configuration for |
snicoll
pushed a commit
that referenced
this pull request
Apr 19, 2019
Spring Session's own configuration support (i.e. SpringHttpSessionConfiguration) will configure the default DefaultCookieSerializer with rememberMeRequestAttribute if SpringSessionRememberMeServices bean has been detected in the application context. In contrast, Spring Boot's auto-configured DefaultCookieSerializer does not do this which results in a different out-of-the-box experience for users that rely on Spring Session's remember-me integration. This commit improves Spring Session DefaultCookieSerializer auto-configuration to match Spring Session's behavior and make the auto-configured DefaultCookieSerializer aware of SpringSessionRememberMeServices bean. See gh-16513
snicoll
added a commit
that referenced
this pull request
Apr 19, 2019
* pr/16513: Polish "Improve DefaultCookieSerializer auto-configuration" Improve DefaultCookieSerializer auto-configuration
Member
|
Thanks @vpavic. I've polished your contribution in 7b94718 - Please note we've reviewed the auto-configuration to avoid having a constructor when a given dependency is used in one place. Rather, we put that in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring Session's own configuration support (i.e.
SpringHttpSessionConfiguration) will configure the defaultDefaultCookieSerializerwithrememberMeRequestAttributeifSpringSessionRememberMeServicesbean has been detected in the application context.In contrast, Spring Boot's auto-configured
DefaultCookieSerializerdoes not do this which results in a different out-of-the-box experience for users that rely on Spring Session's remember-me integration.This PR improves Spring Session
DefaultCookieSerializerauto-configuration to match Spring Session's behavior and make the auto-configuredDefaultCookieSerializeraware ofSpringSessionRememberMeServicesbean.