diff --git a/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/task/TaskExecutionAutoConfiguration.java b/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/task/TaskExecutionAutoConfiguration.java index 977c90cef7fd..c3fce41c0998 100644 --- a/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/task/TaskExecutionAutoConfiguration.java +++ b/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/task/TaskExecutionAutoConfiguration.java @@ -36,6 +36,7 @@ * {@link EnableAutoConfiguration Auto-configuration} for {@link TaskExecutor}. * * @author Stephane Nicoll + * @author Camille Vienot * @since 2.1.0 */ @ConditionalOnClass(ThreadPoolTaskExecutor.class) @@ -48,6 +49,8 @@ public class TaskExecutionAutoConfiguration { */ public static final String APPLICATION_TASK_EXECUTOR_BEAN_NAME = "applicationTaskExecutor"; + public static final String ASYNC_TASK_EXECUTOR_BEAN_NAME = "taskExecutor"; + private final TaskExecutionProperties properties; private final ObjectProvider taskExecutorCustomizers; @@ -79,7 +82,7 @@ public TaskExecutorBuilder taskExecutorBuilder() { } @Lazy - @Bean(name = APPLICATION_TASK_EXECUTOR_BEAN_NAME) + @Bean(name = { APPLICATION_TASK_EXECUTOR_BEAN_NAME, ASYNC_TASK_EXECUTOR_BEAN_NAME }) @ConditionalOnMissingBean(Executor.class) public ThreadPoolTaskExecutor applicationTaskExecutor(TaskExecutorBuilder builder) { return builder.build(); diff --git a/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/task/TaskExecutionAutoConfigurationTests.java b/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/task/TaskExecutionAutoConfigurationTests.java index 00a5cb14f2c0..bac30784bf33 100644 --- a/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/task/TaskExecutionAutoConfigurationTests.java +++ b/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/task/TaskExecutionAutoConfigurationTests.java @@ -38,6 +38,7 @@ import org.springframework.scheduling.annotation.Async; import org.springframework.scheduling.annotation.AsyncResult; import org.springframework.scheduling.annotation.EnableAsync; +import org.springframework.scheduling.annotation.EnableScheduling; import org.springframework.scheduling.concurrent.ThreadPoolTaskExecutor; import org.springframework.test.util.ReflectionTestUtils; @@ -49,6 +50,7 @@ * Tests for {@link TaskExecutionAutoConfiguration}. * * @author Stephane Nicoll + * @author Camille Vienot */ public class TaskExecutionAutoConfigurationTests { @@ -151,6 +153,21 @@ public void enableAsyncUsesAutoConfiguredOneByDefault() { }); } + @Test + public void enableAsyncUsesAutoConfiguredOneByDefaultEvenThoughSchedulingIsConfigured() { + this.contextRunner + .withPropertyValues("spring.task.execution.thread-name-prefix=task-test-") + .withConfiguration( + AutoConfigurations.of(TaskSchedulingAutoConfiguration.class)) + .withUserConfiguration(AsyncConfiguration.class, + SchedulingConfiguration.class, TestBean.class) + .run((context) -> { + TestBean bean = context.getBean(TestBean.class); + String text = bean.echo("something").get(); + assertThat(text).contains("task-test-").contains("something"); + }); + } + private ContextConsumer assertTaskExecutor( Consumer taskExecutor) { return (context) -> { @@ -208,6 +225,12 @@ static class AsyncConfiguration { } + @Configuration + @EnableScheduling + static class SchedulingConfiguration { + + } + static class TestBean { @Async