Skip to content

Consider managing versions for graphql-java-extended-scalars and graphql-java-extended-validation #41690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nmck257 opened this issue Aug 2, 2024 · 3 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply

Comments

@nmck257
Copy link

nmck257 commented Aug 2, 2024

(I couldn't find any existing issue if this has been discussed in the past)

Spring Boot provides version management for com.graphql-java:graphql-java already.

graphql-java-extended-scalars and graphql-java-extended-validation are companion libraries from the same organization, and they align on major version with graphql-java, but not on minor version:
https://github.com/graphql-java/graphql-java-extended-scalars#getting-started
https://github.com/graphql-java/graphql-java-extended-validation?tab=readme-ov-file#using

It's easy for a developer to assume they match precisely, and try to reuse the graphql-java.version property to select a compatible version for the -extended- libraries. This will work if the developer is lucky (eg 22.0 exists for both), but in many cases will fail (as of today, Spring Boot uses 22.1, and that version does not exist for -extended-scalars).

It's also error-prone to rely on the developer to check the value of the version provided by Spring Boot (especially across upgrades) and select the right compatible version of the -extended- libraries.

Could these libraries be added to spring-boot-dependencies?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 2, 2024
@bclozel
Copy link
Member

bclozel commented Aug 2, 2024

This was considered in spring-projects/spring-graphql#242 and declined. I don't think the situation changed since?

@bclozel bclozel added the status: waiting-for-feedback We need additional information before we can continue label Aug 2, 2024
@nmck257
Copy link
Author

nmck257 commented Aug 2, 2024

Ah, yep, thanks for linking that issue. It sounds like a graphql-java bom would be the differentiator here, so, I've raised that topic over on their side: graphql-java/graphql-java#3677

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Aug 2, 2024
@philwebb
Copy link
Member

philwebb commented Aug 2, 2024

We'll close this one for now and keep an eye on graphql-java/graphql-java#3677

@philwebb philwebb closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2024
@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Aug 2, 2024
@philwebb philwebb changed the title Consider managing versions for graphql-java-extended-scalars and graphql-java-extended-validation Consider managing versions for graphql-java-extended-scalars and graphql-java-extended-validation Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

No branches or pull requests

4 participants