Skip to content

DevTools restart doesn't close context when shutdown hook's been disabled #4153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Oct 12, 2015 · 1 comment
Closed
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@wilkinsona
Copy link
Member

I'm not yet sure if this should just be something that we document, or if we should do something smarter. The DevTools currently rely on the application context's shutdown hook to close it during a restart. If you explicitly disable the shutdown hook you end up with a second context being refreshed while the first is still active. If you're working on a web app that fails due to an HTTP port clash.

@philwebb
Copy link
Member

We could perhaps add some kind of additional tracking for contexts that need to be closed. For now I'd settle for a documented known limitation.

@wilkinsona wilkinsona added this to the 1.3.0 milestone Oct 13, 2015
@wilkinsona wilkinsona added the type: documentation A documentation update label Oct 13, 2015
@wilkinsona wilkinsona self-assigned this Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

2 participants