Skip to content

Improve container test code #41164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue Jun 20, 2024 · 0 comments
Closed

Improve container test code #41164

philwebb opened this issue Jun 20, 2024 · 0 comments
Assignees
@philwebb @wilkinsona
Labels
type: task A general task
Milestone
3.2.7

Comments

@philwebb
Copy link
Member

Issue #41146 has identified that our current container test classes could be improved.

Specifically:

  • DockerImageNames should be an enum so that it can be used in an annotation
  • The package should be container not testcontainers since we use the names in Docker compose tests
  • Common testcontainer setup code should be in the same place rather than duplicated across multiple tests
@philwebb philwebb added the type: task A general task label Jun 20, 2024
@philwebb philwebb added this to the 3.2.x milestone Jun 20, 2024
@philwebb philwebb mentioned this issue Jun 20, 2024
Closed
@philwebb philwebb modified the milestones: 3.2.x, 3.2.7 Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

@wilkinsona wilkinsona

Labels
type: task A general task
Projects
None yet
Milestone
3.2.7
Development

No branches or pull requests
2 participants
@philwebb @wilkinsona