Skip to content

LogbackLoggingSystem: make getLoggerContext() protected for easy sub-classing #4096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brenuart opened this issue Oct 5, 2015 · 4 comments
Closed
Labels
type: enhancement A general enhancement

Comments

@brenuart
Copy link
Contributor

brenuart commented Oct 5, 2015

We'd like to reuse/extend LogbackLoggingSystem with additional custom behaviour. For this we need access to the Logback LoggerContext being configured. Unfortunately, LogbackLoggingSystem.getLoggerContext() is private. Would it be possible to make it protected instead?

@snicoll
Copy link
Member

snicoll commented Dec 21, 2015

Can you share what you're trying to change please? Maybe we could give you a way to do that without exposing the whole LoggerContext.

@snicoll snicoll added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 21, 2015
@philwebb philwebb added the type: enhancement A general enhancement label Dec 23, 2015
@spring-projects-issues
Copy link
Collaborator

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues spring-projects-issues added the status: feedback-reminder We've sent a reminder that we need additional information before we can continue label Dec 28, 2015
@brenuart
Copy link
Contributor Author

Request was related to issue #4026
In addition, having access to the LoggerContext allows one to reuse existing code and customise the configuration process. One of the examples is register our own log back actions or property resolving mechanism.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue status: feedback-reminder We've sent a reminder that we need additional information before we can continue labels Dec 28, 2015
@wilkinsona wilkinsona added priority: low and removed status: feedback-provided Feedback has been provided labels Feb 7, 2017
@snicoll
Copy link
Member

snicoll commented May 9, 2018

We're cleaning out the issue tracker and closing issues that we've not seen much demand to fix. Feel free to comment with additional justifications if you feel that this one should not have been closed.

@snicoll snicoll closed this as completed May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

5 participants