Skip to content

Update ConnectionPoolMetricsTests to use ConnectionPool.warmup() #36474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue Jul 20, 2023 · 1 comment
Closed

Update ConnectionPoolMetricsTests to use ConnectionPool.warmup() #36474

wilkinsona opened this issue Jul 20, 2023 · 1 comment
Assignees
@snicoll
Labels
type: task A general task
Milestone
2.7.15

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Jul 20, 2023 •
edited by snicoll
Loading

Upgrading to r2dbc-pool 1.0.1.RELEASE resulted in a failure in ConnectionPoolMetricsTests as the metrics did not match expectations. @mp911de has recommended that we "use ConnectionPool.warmup() and use the metric values from there". We should do that in 2.7.x and later and then try the r2dbc-pool upgrade again in 3.0.x and later.
@wilkinsona wilkinsona added the type: task A general task label Jul 20, 2023
@wilkinsona wilkinsona added this to the 2.7.x milestone Jul 20, 2023
@snicoll snicoll self-assigned this Aug 4, 2023
@snicoll snicoll modified the milestones: 2.7.x, 2.7.15 Aug 4, 2023
@snicoll snicoll mentioned this issue Aug 4, 2023
Closed
@snicoll snicoll closed this as completed in 747dbc3 Aug 4, 2023
@snicoll
Copy link
Member

snicoll commented Aug 4, 2023

I did try locally with 1.0.1.RELEASE and the test passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: task A general task
Projects
None yet
Milestone
2.7.15
Development

No branches or pull requests
2 participants
@snicoll @wilkinsona