You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should be secure by default. It was surprising that even though Spring Security secures every endpoint by default, somehow /error wasn't included in this. Spring Boot 2.0 is now secure by default, too, in that all endpoints, including /error now respect the Spring Security default.
Also with /error it was the case that Spring Security wasn't invoked at all, meaning that things like secure headers, https redirects, and the like weren't consulted as part of the response.
I think that the nod to simpification already in the docs is a good one, too.
The text was updated successfully, but these errors were encountered:
NOTE: It is probably obvious, but in addition to /error I think it would be beneficial to list other endpoints impacted too.
snicoll
changed the title
Boot Migration Guide should call out implications for /error
Spring Boot Migration Guide should call out implications for /error
Sep 19, 2018
snicoll
changed the title
Spring Boot Migration Guide should call out implications for /error
2.0 migration Guide should call out implications for /error
Sep 19, 2018
Could we add an example of how to do that? We might provide a way to ignore as was done in Boot 1.x but first propose they use permitAll (which is better because it allows access but enables other security features).
It isn't obvious when reading the Boot 2.x Migration Guide that one consequence of this:
Is that, where
/error
was once public, it is now secured.The Spring Boot Security 2.0 page does help by saying:
But, it isn't clear to users who are migrating that this includes
/error
.This has caused some confusion and heartburn for users that could be somewhat alleviated by calling it out.
Looks like there is already some of this in the guide:
It may be valuable to add to the guide a bit of the rationale behind the change. Some users mistakenly believe that when they are proactively securing
/error
, that it is an icky workaround instead of the desired practice.Here is some rationale that we could draw from:
/error
wasn't included in this. Spring Boot 2.0 is now secure by default, too, in that all endpoints, including/error
now respect the Spring Security default./error
it was the case that Spring Security wasn't invoked at all, meaning that things like secure headers, https redirects, and the like weren't consulted as part of the response.I think that the nod to simpification already in the docs is a good one, too.
The text was updated successfully, but these errors were encountered: