Skip to content

Create InMemoryReactiveClientRegistrationRepository in web-application-type=none #14350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwinch opened this issue Sep 7, 2018 · 2 comments
Closed

Create InMemoryReactiveClientRegistrationRepository in web-application-type=none #14350

rwinch opened this issue Sep 7, 2018 · 2 comments
Assignees
@mbhave
Labels
type: enhancement A general enhancement
Milestone
2.1.0.M3

Comments

@rwinch
Copy link
Member

rwinch commented Sep 7, 2018

Currently Spring Boot only creates InMemoryReactiveClientRegistrationRepository in web applications. However, it is quite likely that users will want to leverage this with non web applications (i.e. a CLI tool).

It would be nice if InMemoryReactiveClientRegistrationRepository would be created for non web applications too.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 7, 2018
@mbhave
Copy link
Contributor

mbhave commented Sep 7, 2018

We also need to create a ServerOAuth2AuthorizedClientRepository bean.

@mbhave mbhave added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 7, 2018
@mbhave mbhave added this to the 2.1.x milestone Sep 7, 2018
@mbhave mbhave self-assigned this Sep 10, 2018
@mbhave mbhave modified the milestones: 2.1.x, 2.1.0.M3 Sep 10, 2018
@mbhave mbhave closed this as completed in 968a637 Sep 10, 2018
@rwinch
Copy link
Member Author

rwinch commented Sep 11, 2018

Thanks! I can confirm that this is working and improves the setup for those using a non-web application. You can find the diff after these changes here rwinch/webclientoauth2-cli@ed86aed

@rwinch rwinch mentioned this issue Sep 13, 2018
Closed
@wilkinsona wilkinsona mentioned this issue Jun 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbhave mbhave

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.1.0.M3
Development

No branches or pull requests
3 participants
@rwinch @mbhave @spring-projects-issues