Skip to content

Provide access to the CopySpec for BOOT-INF of BootJar as Gradle's War task does for WEB-INF #13000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Apr 30, 2018 · 8 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Apr 30, 2018

Gradle's War task has methods for working with the WEB-INF CopySpec:

  • getWebInf()
  • webInf(Action<CopySpec>)
  • webInf(Closure)

BootJar has no such methods for its CopySpec for BOOT-INF which is analogous to the War task's CopySpec for WEB-INF. When should add both getWebInf() and webInf(Action<CopySpec>). I don't think there's any need for webInf(Closure) as Groovy can happily use the Action variant.

@wilkinsona wilkinsona added the type: enhancement A general enhancement label Apr 30, 2018
@wilkinsona wilkinsona added this to the 2.0.x milestone Apr 30, 2018
@wilkinsona wilkinsona self-assigned this Apr 30, 2018
@wilkinsona
Copy link
Member Author

If there are no objections, I'd like to add the missing methods in 2.0.x as they, arguably, should have been there from the outset.

@wilkinsona wilkinsona added for: stackoverflow A question that's better suited to stackoverflow.com for: team-attention An issue we'd like other members of the team to review type: enhancement A general enhancement and removed for: stackoverflow A question that's better suited to stackoverflow.com type: enhancement A general enhancement labels Apr 30, 2018
@philwebb
Copy link
Member

@wilkinsona would these methods be named getBootInf?

@wilkinsona
Copy link
Member Author

Yeah, I think they’d be:

  • getBootInf()
  • bootInf(Action<CopySpec>)

@philwebb
Copy link
Member

+1 from me then

@wilkinsona
Copy link
Member Author

And now I see why you asked. I used the wrong names in the opening description. Sorry for the confusion.

@wilkinsona wilkinsona modified the milestones: 2.0.x, 2.0.2 May 2, 2018
@wilkinsona wilkinsona removed the for: team-attention An issue we'd like other members of the team to review label May 2, 2018
@wilkinsona
Copy link
Member Author

I'm not sure this is possible without using internal API. Gradle's War task calls an internal addChild() method on its CopySpec. I've reached out to the Gradle team for some guidance. Moving back out to 2.0.x until we know what's possible.

@wilkinsona wilkinsona modified the milestones: 2.0.2, 2.0.x May 2, 2018
@wilkinsona
Copy link
Member Author

This isn't possible without using internal API so I don't think we should do it. I've opened gradle/gradle#5239 to see if the Gradle team can provide the necessary API. In the meantime, I'm going to decline this issue. We can re-open it if Gradle provides the necessary API at some point in the future.

@wilkinsona wilkinsona removed this from the 2.0.x milestone May 3, 2018
@wilkinsona wilkinsona added the status: declined A suggestion or change that we don't feel we should currently apply label May 3, 2018
@wilkinsona wilkinsona changed the title Provide access to the CopySpec for BootJars' BOOT-INF of BootJar as Gradle's War task does for WEB-INF Provide access to the CopySpec for BOOT-INF of BootJar as Gradle's War task does for WEB-INF May 3, 2018
@wilkinsona
Copy link
Member Author

Turns out that this is possible after all.

@wilkinsona wilkinsona reopened this May 8, 2018
@wilkinsona wilkinsona removed the status: declined A suggestion or change that we don't feel we should currently apply label May 8, 2018
@wilkinsona wilkinsona modified the milestone: 2.0.x May 8, 2018
@wilkinsona wilkinsona added this to the 2.0.3 milestone May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants