Skip to content

Commit 548ca63

Browse files
committed
Merge branch '2.4.x'
Closes gh-25364
2 parents 8ec14e2 + 526474f commit 548ca63

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/jdbc/DataSourceBuilder.java

+2
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,8 @@ private static class DataSourceSettingsResolver {
198198
create(classLoader, "oracle.jdbc.datasource.OracleDataSource", OracleDataSourceSettings::new));
199199
addIfAvailable(this.allDataSourceSettings, create(classLoader, "org.h2.jdbcx.JdbcDataSource",
200200
(type) -> new DataSourceSettings(type, (aliases) -> aliases.addAliases("username", "user"))));
201+
addIfAvailable(this.allDataSourceSettings, create(classLoader, "org.postgresql.ds.PGSimpleDataSource",
202+
(type) -> new DataSourceSettings(type, (aliases) -> aliases.addAliases("username", "user"))));
201203
}
202204

203205
private static List<DataSourceSettings> resolveAvailableDataSourceSettings(ClassLoader classLoader) {

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/jdbc/DataSourceBuilderTests.java

+10
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
import org.h2.jdbcx.JdbcDataSource;
3434
import org.junit.jupiter.api.AfterEach;
3535
import org.junit.jupiter.api.Test;
36+
import org.postgresql.ds.PGSimpleDataSource;
3637

3738
import org.springframework.jdbc.datasource.SimpleDriverDataSource;
3839

@@ -129,6 +130,15 @@ void dataSourceCanBeCreatedWithH2JdbcDataSource() {
129130
assertThat(h2DataSource.getUser()).isEqualTo("test");
130131
}
131132

133+
@Test
134+
void dataSourceCanBeCreatedWithPGDataSource() {
135+
this.dataSource = DataSourceBuilder.create().url("jdbc:postgresql://localhost/test")
136+
.type(PGSimpleDataSource.class).username("test").build();
137+
assertThat(this.dataSource).isInstanceOf(PGSimpleDataSource.class);
138+
PGSimpleDataSource pgDataSource = (PGSimpleDataSource) this.dataSource;
139+
assertThat(pgDataSource.getUser()).isEqualTo("test");
140+
}
141+
132142
@Test
133143
void dataSourceAliasesAreOnlyAppliedToRelevantDataSource() {
134144
this.dataSource = DataSourceBuilder.create().url("jdbc:h2:test").type(TestDataSource.class).username("test")

0 commit comments

Comments
 (0)