Skip to content

Commit 516582f

Browse files
committed
Merge branch '2.3.x'
Closes gh-22744
2 parents b51e612 + cccf9c2 commit 516582f

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/jdbc/DataSourceHealthContributorAutoConfigurationTests.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ void runWhenMultipleDataSourceBeansShouldCreateCompositeIndicator() {
7474

7575
@Test
7676
void runWithRoutingAndEmbeddedDataSourceShouldIncludeRoutingDataSource() {
77-
this.contextRunner.withUserConfiguration(EmbeddedDataSourceConfiguration.class, RoutingDatasourceConfig.class)
77+
this.contextRunner.withUserConfiguration(EmbeddedDataSourceConfiguration.class, RoutingDataSourceConfig.class)
7878
.run((context) -> {
7979
CompositeHealthContributor composite = context.getBean(CompositeHealthContributor.class);
8080
assertThat(composite.getContributor("dataSource")).isInstanceOf(DataSourceHealthIndicator.class);
@@ -85,7 +85,7 @@ void runWithRoutingAndEmbeddedDataSourceShouldIncludeRoutingDataSource() {
8585

8686
@Test
8787
void runWithRoutingAndEmbeddedDataSourceShouldNotIncludeRoutingDataSourceWhenIgnored() {
88-
this.contextRunner.withUserConfiguration(EmbeddedDataSourceConfiguration.class, RoutingDatasourceConfig.class)
88+
this.contextRunner.withUserConfiguration(EmbeddedDataSourceConfiguration.class, RoutingDataSourceConfig.class)
8989
.withPropertyValues("management.health.db.ignore-routing-datasources:true").run((context) -> {
9090
assertThat(context).doesNotHaveBean(CompositeHealthContributor.class);
9191
assertThat(context).hasSingleBean(DataSourceHealthIndicator.class);
@@ -95,13 +95,13 @@ void runWithRoutingAndEmbeddedDataSourceShouldNotIncludeRoutingDataSourceWhenIgn
9595

9696
@Test
9797
void runWithOnlyRoutingDataSourceShouldIncludeRoutingDataSource() {
98-
this.contextRunner.withUserConfiguration(RoutingDatasourceConfig.class)
98+
this.contextRunner.withUserConfiguration(RoutingDataSourceConfig.class)
9999
.run((context) -> assertThat(context).hasSingleBean(RoutingDataSourceHealthIndicator.class));
100100
}
101101

102102
@Test
103103
void runWithOnlyRoutingDataSourceShouldCrashWhenIgnored() {
104-
this.contextRunner.withUserConfiguration(RoutingDatasourceConfig.class)
104+
this.contextRunner.withUserConfiguration(RoutingDataSourceConfig.class)
105105
.withPropertyValues("management.health.db.ignore-routing-datasources:true")
106106
.run((context) -> assertThat(context).hasFailed().getFailure()
107107
.hasRootCauseInstanceOf(IllegalArgumentException.class));
@@ -140,7 +140,7 @@ DataSource testDataSource() {
140140
}
141141

142142
@Configuration(proxyBeanMethods = false)
143-
static class RoutingDatasourceConfig {
143+
static class RoutingDataSourceConfig {
144144

145145
@Bean
146146
AbstractRoutingDataSource routingDataSource() {

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/format/WebConversionServiceTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,10 +138,10 @@ void hyphenatedIsoOffsetDateTimeFormat() {
138138

139139
private void isoOffsetDateTimeFormat(DateTimeFormatters formatters) {
140140
WebConversionService conversionService = new WebConversionService(formatters);
141-
OffsetDateTime offsetdate = OffsetDateTime.of(LocalDate.of(2020, 4, 26), LocalTime.of(12, 45, 23),
141+
OffsetDateTime offsetDateTime = OffsetDateTime.of(LocalDate.of(2020, 4, 26), LocalTime.of(12, 45, 23),
142142
ZoneOffset.ofHoursMinutes(1, 30));
143-
assertThat(conversionService.convert(offsetdate, String.class))
144-
.isEqualTo(DateTimeFormatter.ISO_OFFSET_DATE_TIME.format(offsetdate));
143+
assertThat(conversionService.convert(offsetDateTime, String.class))
144+
.isEqualTo(DateTimeFormatter.ISO_OFFSET_DATE_TIME.format(offsetDateTime));
145145
}
146146

147147
@Test

spring-boot-project/spring-boot-docs/src/docs/asciidoc/production-ready-features.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2127,7 +2127,7 @@ To register custom metrics, inject `MeterRegistry` into your component, as shown
21272127
include::{code-examples}/actuate/metrics/MetricsMeterRegistryInjectionExample.java[tag=component]
21282128
----
21292129
2130-
If you metrics depend on other beans, it is recommend that you use a `MeterBinder` to register them, as shown in the following example:
2130+
If your metrics depend on other beans, it is recommended that you use a `MeterBinder` to register them, as shown in the following example:
21312131
21322132
[source,java,indent=0]
21332133
----
@@ -2136,7 +2136,7 @@ include::{code-examples}/actuate/metrics/SampleMeterBinderConfiguration.java[tag
21362136
21372137
Using a `MeterBinder` ensures that the correct dependency relationships are set up and that the bean is available when the metric's value is retrieved.
21382138
By default, metrics from all `MeterBinder` beans will be automatically bound to the Spring-managed `MeterRegistry`.
2139-
A `MeterBinder` implementation can also be useful if you find that you repeatedly instrument a suite of metrics across components or applications..
2139+
A `MeterBinder` implementation can also be useful if you find that you repeatedly instrument a suite of metrics across components or applications.
21402140
21412141
21422142

0 commit comments

Comments
 (0)