Skip to content

Migrate to SLF4J #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ptahchiev opened this issue Feb 15, 2020 · 1 comment
Closed

Migrate to SLF4J #3665

ptahchiev opened this issue Feb 15, 2020 · 1 comment
Labels
status: declined Features that we don't intend to implement or Bug reports that are invalid or missing enough details

Comments

@ptahchiev
Copy link

At the moment you are using commons-logging and that one does not support features like embedding placeholders like this:

LOG.error ("Item {} is wrong", itemId);

SLF4J supports this, and is also implementation agnostic. Please consider switching to SLF4J
@fmbenhassine fmbenhassine added the status: waiting-for-triage Issues that we did not analyse yet label Feb 17, 2020
@fmbenhassine
Copy link
Contributor

Being based on Spring Framework, Spring Batch follows the same choice as SF in regards to the logging framework for consistency. Here are some issues that explain why SF is still using commons-logging:

@fmbenhassine fmbenhassine added status: declined Features that we don't intend to implement or Bug reports that are invalid or missing enough details and removed status: waiting-for-triage Issues that we did not analyse yet labels Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: declined Features that we don't intend to implement or Bug reports that are invalid or missing enough details
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fmbenhassine @ptahchiev