Use LinkedHashMap for CORS configurations in CorsGatewayFilterApplicationListener to preserve insertion order. Fixes GH-3805. #3822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavor300
force-pushed
the
fixes-gh-3805-linkedhashmap-global-cors-configurations-application-listener
branch
from
3d37419 to
98f103c
Compare
|
Can you submit this against the 4.1.x branch? We can merge it forward from there. |
…tionListener to preserve insertion order. Fixes spring-cloudGH-3805. Signed-off-by: Yavor Chamov <[email protected]>
…tionListener to preserve insertion order. Fixes spring-cloudGH-3805. Signed-off-by: Yavor Chamov <[email protected]>
…tionListener to preserve insertion order. Fixes spring-cloudGH-3805. Signed-off-by: Yavor Chamov <[email protected]>
yavor300
force-pushed
the
fixes-gh-3805-linkedhashmap-global-cors-configurations-application-listener
branch
from
a04b4bc to
efa9e1d
Compare
|
Changed base branch to 4.1.x |
…tionListener to preserve insertion order. Fixes spring-cloudGH-3805. Signed-off-by: Yavor Chamov <[email protected]>
|
The tests are still failing |
…tionListener to preserve insertion order. Fixes spring-cloudGH-3805. Signed-off-by: Yavor Chamov <[email protected]>
…tionListener to preserve insertion order. Fixes spring-cloudGH-3805. Signed-off-by: Yavor Chamov <[email protected]>
yavor300
deleted the
fixes-gh-3805-linkedhashmap-global-cors-configurations-application-listener
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use LinkedHashMap for CORS configurations to preserve insertion order
Preserving the insertion order of CORS configurations ensures consistent behavior when resolving matching paths.
This change addresses the issue where unordered HashMap usage could result in inconsistent matching behavior.
Fixes spring-cloud/spring-cloud-gateway#3805